On Mon, 4 Jan 2010, Henri Verbeet wrote:
I dont see a reason to take that warning serious, as its not a problem
in any case. in kernel32 it just happens because we use a Macro.
Taking that case(v==1) out of the Macro leads to harder readable code.
So IMHO i would not make -Wlogical-op the
On 01/03/2010 10:12 PM, Gerald Pfeifer wrote:
On Sun, 3 Jan 2010, Austin English wrote:
On my FreeBSD test system I am see no warnings triggered by -Wlogical-op
any more. How does it look on your side?
ole32:
usrmarshal.c:485: warning: logical ?? with non-zero constant will
always evaluate as
2010/1/4 Paul Vriens paul.vriens.w...@gmail.com:
On 01/03/2010 10:12 PM, Gerald Pfeifer wrote:
On Sun, 3 Jan 2010, Austin English wrote:
On my FreeBSD test system I am see no warnings triggered by -Wlogical-op
any more. How does it look on your side?
ole32:
usrmarshal.c:485: warning:
Gerald Pfeifer schrieb:
I had a patch for this one (comctl32/tests) which I received feedback on
and need to brush up. I should be able to do so coming week. Anybody
volunteering to look into the other ones?
kernel32/tests:
atom.c:70: warning: logical ?||? with non-zero constant will
2010/1/4 André Hentschel n...@dawncrow.de:
I dont see a reason to take that warning serious, as its not a problem in any
case. in kernel32 it just happens because we use a Macro. Taking that
case(v==1) out of the Macro leads to harder readable code.
So IMHO i would not make -Wlogical-op the
Henri Verbeet schrieb:
2010/1/4 André Hentschel n...@dawncrow.de:
I dont see a reason to take that warning serious, as its not a problem in
any case. in kernel32 it just happens because we use a Macro. Taking that
case(v==1) out of the Macro leads to harder readable code.
So IMHO i would
On Tue, 23 Jun 2009, Paul Vriens wrote:
For those interested, here's the make log in Monday's git. 94 warnings
for me.
Sent 3 patches based on your log.
I have less (55) warnings on 4.3.2 btw, but most look like false positives.
On my FreeBSD test system I am see no warnings triggered by
On Sun, Jan 3, 2010 at 4:13 AM, Gerald Pfeifer ger...@pfeifer.com wrote:
On Tue, 23 Jun 2009, Paul Vriens wrote:
For those interested, here's the make log in Monday's git. 94 warnings
for me.
Sent 3 patches based on your log.
I have less (55) warnings on 4.3.2 btw, but most look like false
On Sun, 3 Jan 2010, Austin English wrote:
On my FreeBSD test system I am see no warnings triggered by -Wlogical-op
any more. How does it look on your side?
ole32:
usrmarshal.c:485: warning: logical ?? with non-zero constant will
always evaluate as true
usrmarshal.c:1098: warning: logical ??
Austin English wrote:
On Fri, Jun 19, 2009 at 12:35 PM, Gerald Pfeiferger...@pfeifer.com wrote:
On Fri, 19 Jun 2009, Paul Vriens wrote:
I have about 70 warnings with 4.3.2.
I already sent two patches and found a few more bugs. If you want I can
start sending in patches for those as well
On Fri, 19 Jun 2009, Ben Klein wrote:
diff --git a/configure.ac b/configure.ac
index bef311e..3f7a657 100644
--- a/configure.ac
+++ b/configure.ac
@@ -1385,8 +1385,9 @@ then
WINE_TRY_CFLAGS([-fno-builtin],[AC_SUBST(BUILTINFLAG,-fno-builtin)])
WINE_TRY_CFLAGS([-fno-strict-aliasing])
On Thu, 18 Jun 2009, Austin English wrote:
Causes 106 more warnings on 4.3.3 of this sort:
tab.c:693: warning: logical ?? with non-zero constant will always
evaluate as true
cert.c:1627: warning: logical ?||? with non-zero constant will always
evaluate as true
This is strange. In that case,
Gerald Pfeifer wrote:
On Thu, 18 Jun 2009, Austin English wrote:
Causes 106 more warnings on 4.3.3 of this sort:
tab.c:693: warning: logical ?? with non-zero constant will always
evaluate as true
cert.c:1627: warning: logical ?||? with non-zero constant will always
evaluate as true
This is
On Fri, 19 Jun 2009, Rein Klazes wrote:
cert.c:1627: warning: logical ?||? with non-zero constant will always
evaluate as true
That (in dlls/crypt32/tests) looks like a real bug to me.
Indeed. And Alexandre committed a fix of mine in the last 24 hours. ;-)
Gerald
On Fri, 19 Jun 2009, Paul Vriens wrote:
I have about 70 warnings with 4.3.2.
I already sent two patches and found a few more bugs. If you want I can
start sending in patches for those as well (don't want to duplicate work
of course).
Thanks for checking to help avoid duplicate work, Paul;
On Thu, Jun 18, 2009 at 12:32 PM, Gerald Pfeiferger...@pfeifer.com wrote:
I verified this does not cause any extra warnings with GCC 4.4, whereas
GCC 4.5 will become quite a bit more useful in that regard and thus help
spot any issues.
As with -Wtype-limits that I suggested last year, I
2009/6/19 Austin English austinengl...@gmail.com:
On Thu, Jun 18, 2009 at 12:32 PM, Gerald Pfeiferger...@pfeifer.com wrote:
I verified this does not cause any extra warnings with GCC 4.4, whereas
GCC 4.5 will become quite a bit more useful in that regard and thus help
spot any issues.
As
On Thu, 18 Jun 2009 16:01:20 -0500, you wrote:
cert.c:1627: warning: logical || with non-zero constant will always
evaluate as true
That (in dlls/crypt32/tests) looks like a real bug to me.
Rein.
18 matches
Mail list logo
