Vitaliy Margolen <[EMAIL PROTECTED]> writes:
> Sure but we call TlsGetValue() which does set LastError. So unless we can
> avoid
> that call (which I doubt) we have to do something extra to preserve the
> LastError.
If an app depends on it, yes.
> No I don't have any games directly. But I had f
Monday, August 7, 2006, 3:52:51 AM, Alexandre Julliard wrote:
> Vitaliy Margolen <[EMAIL PROTECTED]> writes:
>> Anything wrong with this patch? Test case clearly shows that
>> we should preserve the LastError.
> In general, saving/restoring last error is discouraged, the function
> should be fixe
Vitaliy Margolen <[EMAIL PROTECTED]> writes:
> Anything wrong with this patch? Test case clearly shows that
> we should preserve the LastError.
In general, saving/restoring last error is discouraged, the function
should be fixed to not change it at all. Do you have an app that
depends on this?
-
Saturday, July 29, 2006, 7:28:10 PM, Vitaliy Margolen wrote:
> ChangeLog:
> user: Preserve LastError.
> dlls/user/tests/input.c |4
> dlls/winex11.drv/x11drv.h |3 +++
> 2 files changed, 7 insertions(+), 0 deletions(-)
Anything wrong with this patch? Test case clearly shows that
w
Sunday, July 30, 2006, 6:29:43 AM, Detlef Riekenberg wrote:
> Vitaliy Margolen wrote:
>> ChangeLog:
>> user: Preserve LastError.
> You can move the ok() for GetLastError() direct after GetKeyNameTextA():
>> +SetLastError(0xdeadbeef);
>> len = GetKeyNameTextA(i << 16, buff, sizeof(
Vitaliy Margolen wrote:
> ChangeLog:
> user: Preserve LastError.
You can move the ok() for GetLastError() direct after GetKeyNameTextA():
> +SetLastError(0xdeadbeef);
> len = GetKeyNameTextA(i << 16, buff, sizeof(buff));
> +ok( GetLastError() == 0xdeadbeef,
> +
