Re: wined3d: Set wrapmode for cubemags to clamp regardeless of the sampler state

2007-03-12 Thread H. Verbeet
On 12/03/07, H. Verbeet <[EMAIL PROTECTED]> wrote: I've written a test for this, I'll send it tomorrow together with some other patches. Since this patch doesn't appear to have been applied yet, I can't submit my test yet. I've attached it to this mail instead. --- dlls/d3d9/tests/visual.c |

Re: wined3d: Set wrapmode for cubemags to clamp regardeless of the sampler state

2007-03-11 Thread H. Verbeet
On 11/03/07, Stefan Dösinger <[EMAIL PROTECTED]> wrote: But I cannot think of any good way to test this, so I prefer to wait for an application to show up what can go wrong :-) I've written a test for this, I'll send it tomorrow together with some other patches.

Re: wined3d: Set wrapmode for cubemags to clamp regardeless of the sampler state

2007-03-11 Thread Stefan Dösinger
> I adapted a Directx9 HLSL tutorial to display a black cubemap with one > white line on one edge of one side and visually (by hand or better to say > by eye) confirmed that the line is not "mirrored" on the opposite edge. I'd say the patch is fine. Anything else but clamp to edge does not make sen

Re: wined3d: Set wrapmode for cubemags to clamp regardeless of the sampler state

2007-03-10 Thread Fabian Bieler
> Am Samstag 10 März 2007 15:02 schrieb Fabian Bieler: > > This Patch forces GL_CLAMP_TO_EDGE on all cubemaps. > > > > I tested this on XP with some Radeon X1???. > > > > Also, this fixes some renderissues Half-Life 2. > Say, does that fix the strange quad boarders like in this screenshot? > http

Re: wined3d: Set wrapmode for cubemags to clamp regardeless of the sampler state

2007-03-10 Thread Stefan Dösinger
Am Samstag 10 März 2007 15:02 schrieb Fabian Bieler: > This Patch forces GL_CLAMP_TO_EDGE on all cubemaps. > > I tested this on XP with some Radeon X1???. > > Also, this fixes some renderissues Half-Life 2. Say, does that fix the strange quad boarders like in this screenshot? http://bugs.winehq.or