Re: ddraw [try 2]: SetCooperativeLevel with Full screen + exclusive + normal is authorized

2010-08-24 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4710 Your paranoid

Re: ddraw [try 2]: SetCooperativeLevel with Full screen + exclusive + normal is authorized

2010-08-24 Thread Stefan Dösinger
Hi, Can you add a test that tests in which mode ddraw is after such a call? Specfically, try to create a double buffered primary surface. If this succeeds, ddraw is in fullscreen mode. If ddraw is in normal mode you'll get DDERR_NOEXCLUSIVEMODE (or similar) back. Am 24.08.2010 um 10:00 schrieb

Re: ddraw [try 2]: SetCooperativeLevel with Full screen + exclusive + normal is authorized

2010-08-24 Thread Henri Verbeet
This looks suspicious to me, you have to assume the code wasn't just added for the hell of it, even though with ddraw you're never quite sure. Do other ddraw versions behave the same? Please don't add trailing spaces, neither in the code nor in TRACEs.

Re : ddraw [try 2]: SetCooperativeLevel with Full screen + exclusive + normal is authorized

2010-08-24 Thread paulo lesgaz
[try 2]: SetCooperativeLevel with Full screen + exclusive + normal is authorized This looks suspicious to me, you have to assume the code wasn't just added for the hell of it, even though with ddraw you're never quite sure. Do other ddraw versions behave the same? Please don't add trailing spaces

Re : ddraw [try 2]: SetCooperativeLevel with Full screen + exclusive + normal is authorized

2010-08-24 Thread paulo lesgaz
Such tests are what you were thinking about? They all passed on my real vista box. David De : Stefan Dösinger stefandoesin...@gmx.at À : wine-devel@winehq.org Envoyé le : Mar 24 août 2010, 11h 30min 59s Objet : Re: ddraw [try 2]: SetCooperativeLevel with Full

Re: Re : ddraw [try 2]: SetCooperativeLevel with Full screen + exclusive + normal is authorized

2010-08-24 Thread Stefan Dösinger
-devel@winehq.org Envoyé le : Mar 24 août 2010, 11h 30min 59s Objet : Re: ddraw [try 2]: SetCooperativeLevel with Full screen + exclusive + normal is authorized Hi, Can you add a test that tests in which mode ddraw is after such a call? Specfically, try to create a double buffered primary

Re : Re : ddraw [try 2]: SetCooperativeLevel with Full screen + exclusive + normal is authorized

2010-08-24 Thread paulo lesgaz
, 16h 44min 38s Objet : Re: Re : ddraw [try 2]: SetCooperativeLevel with Full screen + exclusive + normal is authorized I think those tests should do, but have a few spelling issues and you're not releasing the surface. So if I understand things correctly: *) NORMAL | FULLSCREEN | EXCLUSIVE

Re: Re : Re : ddraw [try 2]: SetCooperativeLevel with Full screen + exclusive + normal is authorized

2010-08-24 Thread Stefan Dösinger
Am 24.08.2010 um 17:48 schrieb paulo lesgaz: Is this patch correct to test d3d7 and d3d2 SetCooperativeLevel? For now, all the tests pass on a real vista box. Actually, I missed something: The exising test tests IDirectDraw, not IDirectDraw7. So it is testing the oldest ddraw interface. Can

Re : Re : Re : ddraw [try 2]: SetCooperativeLevel with Full screen + exclusive + normal is authorized

2010-08-24 Thread paulo lesgaz
: ddraw [try 2]: SetCooperativeLevel with Full screen + exclusive + normal is authorized Am 24.08.2010 um 17:48 schrieb paulo lesgaz: Is this patch correct to test d3d7 and d3d2 SetCooperativeLevel? For now, all the tests pass on a real vista box. Actually, I missed something: The exising test tests