Re: Rejected patches needing review.

2008-09-16 Thread Darragh Bailey
On Mon, Sep 15, 2008 at 11:27:34PM +0200, Peter Dons Tychsen wrote: Hello. I have a problem loading a specific proprietary driver. I traced the problem to two bugs in: - services - winedevice The two bugs caused the loading to fail. I created and tested two fixes to solve the problem,

Re: Rejected patches needing review.

2008-09-16 Thread Juan Lang
Hi Peter, diff --git a/programs/services/services.c b/programs/services/services.c index 36ed117..cd71a1f 100644 --- a/programs/services/services.c +++ b/programs/services/services.c @@ -106,9 +106,9 @@ static DWORD load_service_config(HKEY hKey, struct service_entry *entry) return err;

Re: Rejected patches needing review.

2008-09-16 Thread Michael Karcher
Am Dienstag, den 16.09.2008, 07:58 -0700 schrieb Juan Lang: Hi Peter, diff --git a/programs/services/services.c b/programs/services/services.c index 36ed117..cd71a1f 100644 --- a/programs/services/services.c +++ b/programs/services/services.c @@ -106,9 +106,9 @@ static DWORD

Re: Rejected patches needing review.

2008-09-16 Thread Peter Dons Tychsen
Hello Michael. Thanks for your input (and Juan and Austin). Peter, are you sure that windows will handle REG_SZ *only* in the DependOnService case and fail if you have a REG_SZ in DependOnGroup? No. But i did not want to change the behavior for anything else than the scenario that i had been

Re: Rejected patches needing review.

2008-09-16 Thread Michael Karcher
Am Mittwoch, den 17.09.2008, 01:17 +0200 schrieb Peter Dons Tychsen: Peter, are you sure that windows will handle REG_SZ *only* in the DependOnService case and fail if you have a REG_SZ in DependOnGroup? No. But i did not want to change the behavior for anything else than the scenario that i