Hi Andre,
I fixed the strange problems in try8 (
http://www.winehq.org/pipermail/wine-patches/2009-June/074340.html ) and it
still dont get commit.
can you please do a review for this try? (Just say it, if it gets disturbing
you.)
This one looks fine to me. And don't worry, you're not
André Hentschel n...@dawncrow.de wrote:
Fair enough. We tend to mimic Windows behavior. I hadn't checked
this myself. Note that it still should be Install*.exe rather than
Instal*.exe, at least in English.
--Juan
My tests worked with Instal*.exe files on english Windows, too.
I bet it is
2009/6/16 Dmitry Timoshkov dmi...@codeweavers.com:
André Hentschel n...@dawncrow.de wrote:
Fair enough. We tend to mimic Windows behavior. I hadn't checked
this myself. Note that it still should be Install*.exe rather than
Instal*.exe, at least in English.
--Juan
My tests worked with
Dmitry Timoshkov schrieb:
André Hentschel n...@dawncrow.de wrote:
Fair enough. We tend to mimic Windows behavior. I hadn't checked
this myself. Note that it still should be Install*.exe rather than
Instal*.exe, at least in English.
--Juan
My tests worked with Instal*.exe files on english
Can someone please review my patch
http://www.winehq.org/pipermail/wine-patches/2009-June/074195.html.
Its about the Installer-Button in Appwiz.cpl
Thanks
Best Regards André Hentschel
Hi André,
Can someone please review my patch
http://www.winehq.org/pipermail/wine-patches/2009-June/074195.html.
I have a couple minor comments:
+
+ IDS_INSTALL_FILTER, Installation
Program\0*Instal*.exe;*Setup*.exe;*.msi\0Programs\0*.com;*.cmd;*.exe\0All
Files (*.*)\0*.*\0\0
Nit: the
Juan Lang schrieb:
Hi André,
Can someone please review my patch
http://www.winehq.org/pipermail/wine-patches/2009-June/074195.html.
I have a couple minor comments:
+
+ IDS_INSTALL_FILTER, Installation
Program\0*Instal*.exe;*Setup*.exe;*.msi\0Programs\0*.com;*.cmd;*.exe\0All
Files
First thing, i tested it on some Win-Versions, and it took everything like
Instal*.exe and *Setup*.exe
Really, name a exe-file Instalblahblah.exe and the installer-dialog will
show it.
Second thing, the .com and .cmd belongs to normal Program-selection, not to
the installers. but we can
Juan Lang schrieb:
First thing, i tested it on some Win-Versions, and it took everything like
Instal*.exe and *Setup*.exe
Really, name a exe-file Instalblahblah.exe and the installer-dialog will
show it.
Second thing, the .com and .cmd belongs to normal Program-selection, not to
the installers.
Thanks André.
My tests worked with Instal*.exe files on english Windows, too.
I bet it is because of the instal~1.exe writing. (8.3 and 6##.3)
Ah, right. Very good, leave this as it is then.
Sorry for the sloppy review, there are a couple more things I'd like
to ask about:
My tests worked
10 matches
Mail list logo
