Re: Request for review: [PATCH] Resize fullscreen window when DirectDraw changes the display mode [resubmit 4]

2009-10-08 Thread Johan Gill
On Wed, Aug 12, 2009 at 3:05 AM, Stefan Dösinger stefandoesin...@gmx.atwrote: Am Tuesday 11 August 2009 23:43:33 schrieb Johan Gill: There is IWineD3DDeviceImpl_SetupFullscreenWindow, but that one is not exported so it can't be called from ddraw as it is. Calling it from within

Re: Request for review: [PATCH] Resize fullscreen window when DirectDraw changes the display mode [resubmit 4]

2009-08-12 Thread Stefan Dösinger
Am Wednesday 12 August 2009 03:05:43 schrieb Stefan Dösinger: Am Tuesday 11 August 2009 23:43:33 schrieb Johan Gill: There is IWineD3DDeviceImpl_SetupFullscreenWindow, but that one is not exported so it can't be called from ddraw as it is. Calling it from within

Re: Request for review: [PATCH] Resize fullscreen window when DirectDraw changes the display mode [resubmit 4]

2009-08-11 Thread Johan Gill
On Wed, Aug 5, 2009 at 7:51 PM, Stefan Dösinger stefandoesin...@gmx.atwrote: Am Wednesday 05 August 2009 18:58:42 schrieb Johan Gill: On Wed, Jul 29, 2009 at 11:55 PM, Johan Gill johan.g...@gmail.com wrote: This patch fixes bug 17215. Since the patch was seemingly dropped, I made some

Re: Request for review: [PATCH] Resize fullscreen window when DirectDraw changes the display mode [resubmit 4]

2009-08-11 Thread Stefan Dösinger
Am Tuesday 11 August 2009 23:43:33 schrieb Johan Gill: There is IWineD3DDeviceImpl_SetupFullscreenWindow, but that one is not exported so it can't be called from ddraw as it is. Calling it from within IWineD3DDevice_SetDisplayMode seems troublesome since the hwnd to use is not always

Request for review: [PATCH] Resize fullscreen window when DirectDraw changes the display mode [resubmit 4]

2009-08-05 Thread Johan Gill
On Wed, Jul 29, 2009 at 11:55 PM, Johan Gill johan.g...@gmail.com wrote: This patch fixes bug 17215. Since the patch was seemingly dropped, I made some test improvements and resubmit it. The tests pass on Windows XP, and of course Wine. Suggested changelog: In DirectDraw fullscreen mode,

Re: Request for review: [PATCH] Resize fullscreen window when DirectDraw changes the display mode [resubmit 4]

2009-08-05 Thread Stefan Dösinger
Am Wednesday 05 August 2009 18:58:42 schrieb Johan Gill: On Wed, Jul 29, 2009 at 11:55 PM, Johan Gill johan.g...@gmail.com wrote: This patch fixes bug 17215. Since the patch was seemingly dropped, I made some test improvements and resubmit it. The tests pass on Windows XP, and of course