On Fri, 2008-10-03 at 12:01 -0500, Austin English wrote:
> +if (apc_user)
> + if (warn) {
> + FIXME("I/O completion on lock not implemented yet\n");
> + warn = FALSE;
> + }
It's a style thing, but I for one would much prefer
brackets around the outer if to pre
Hi Austin,
> Not sure if this is the best way to go about this or not. Any advice
> appreciated (or if anyone else wants to silence it :-P).
You're close. The only fix is:
+BOOLEAN warn = TRUE;
should be static. (Otherwise it'll be TRUE every time the function is
called, so it'll always
Austin English wrote:
> Howdy,
>
> I was taking a look at some of the noisy fixme's, and wanted some
> feedback on the attached patch.
> This particular fixme is _really_ noisy...out of this
> (http://bugs.winehq.org/attachment.cgi?id=16447)
> log, it has 9635 of the 13117 lines!
>
> "fixme:ntdll:N
2008/10/3 Austin English <[EMAIL PROTECTED]>:
> Howdy,
>
> I was taking a look at some of the noisy fixme's, and wanted some
> feedback on the attached patch.
That patch won't make the FIXME any less noisy, for one.
> This particular fixme is _really_ noisy...out of this
> (http://bugs.winehq.org/
On Fri, Oct 3, 2008 at 11:46 AM, Austin English <[EMAIL PROTECTED]> wrote:
> Howdy,
>
> I was taking a look at some of the noisy fixme's, and wanted some
> feedback on the attached patch.
> This particular fixme is _really_ noisy...out of this
> (http://bugs.winehq.org/attachment.cgi?id=16447)
> lo
On Fri, 2008-10-03 at 11:46 -0500, Austin English wrote:
> +BOOLEAN warn = TRUE;
This has to be static, else it will always be TRUE.
--
Dimi Paun <[EMAIL PROTECTED]>
Lattica, Inc.
Howdy,
I was taking a look at some of the noisy fixme's, and wanted some
feedback on the attached patch.
This particular fixme is _really_ noisy...out of this
(http://bugs.winehq.org/attachment.cgi?id=16447)
log, it has 9635 of the 13117 lines!
"fixme:ntdll:NtLockFile I/O completion on lock not i
