Re[2]: Tab control update

2004-10-04 Thread Vitaliy Margolen
>>I can see how you can send ASCII message first and then send >>UNICODE message which will screw things up. > I don't know what you mean. Can you give an example? Sorry, I haven't paid attention to how we store text. So it shouldn't be an issue. >>You missed insert items with text part inside cre

Re: Tab control update

2004-10-04 Thread Robert Shearman
Jon Griffiths wrote: Combine all Unicode/Ascii calls together I'm not sure here, but should it be based on the unicode state of the whole control rather which message got sent to it? This refers to processing the messages using the same code. e.g. between TAB_InsertItemA/

Re: Tab control update

2004-10-03 Thread Jon Griffiths
Hi, >It would be really nice to separate formatting changes from other > changes. It's hard to see what's got changed and what not. Agreed, see my reply to Robert on that. >>"Only create a scroll control when/if we need one (like native)" >Nothing got changed. It's being created when needed, and

Re: Tab control update

2004-10-02 Thread Vitaliy Margolen
Looks ok to me with few exceptions: It would be really nice to separate formatting changes from other changes. It's hard to see what's got changed and what not. >+#define MIN_ICONTAB_WIDTH 54 /* Magic number, but it works */ >+ if (icon_width > MIN_ICONTAB_WIDTH) >+ curr->rect.right

Re: Tab control update

2004-10-01 Thread Jon Griffiths
Hi, > Nice. While you're at it (and have it fresh in your mind), can you > please also provide an audit (and a list of TODOs) as per comctl > 6.0? It will be a while afraid, I'm really busy with work ATM. My first priorities when i get some free time are to finish clearing my patch tree for oleau

Re: Tab control update

2004-10-01 Thread Jon Griffiths
Hi, > There is no point in sending WM_QUERYUISTATE. I believe it is only > really used for the toolbar control, but the native comctl32 has a > common framework that means it is sent for all controls. Sure, it helps when diffing the traces of native and builtin though. By sending this and creat

Re: Tab control update

2004-10-01 Thread Robert Shearman
Jon Griffiths wrote: Hi, There is no point in sending WM_QUERYUISTATE. I believe it is only really used for the toolbar control, but the native comctl32 has a common framework that means it is sent for all controls. Sure, it helps when diffing the traces of native and builtin though. By s

Re: Tab control update

2004-10-01 Thread Robert Shearman
Jon Griffiths wrote: Hi, A fairly large update to the tab control. This makes it work as per native in my app. Regards, Jon +dlls/comctl32/tab.c dlls/comctl32/tests/tab.c Items can be variable sized; use an accessor to retrieve them Send WM_NOTIFYFORMAT/WM_QUERYUISTATE to match native messa

Re: Tab control update

2004-10-01 Thread Dimitrie O. Paun
On Fri, Oct 01, 2004 at 07:58:23AM -0700, Jon Griffiths wrote: > Hi, > > A fairly large update to the tab control. This makes it work as per > native in my app. Nice. While you're at it (and have it fresh in your mind), can you please also provide an audit (and a list of TODOs) as per comctl 6.0?