Re: Total bidi regression

2007-09-26 Thread Shachar Shemesh
Maarten Lankhorst wrote: > > I may have slightly misunderstood those flags then. I was under the > impression that the FORCE flags would be similar to LRO/RLO. The only thing that behaves like LRO and RLO are LRO and RLO. Believe you me, no one was more surprised than me when I found out that Windo

Re: Total bidi regression

2007-09-26 Thread Maarten Lankhorst
Shachar Shemesh schreef: > Maarten Lankhorst wrote: > >> Shachar Shemesh schreef: >> >> >>> Maarten Lankhorst wrote: >>> >>> >>> If you want it back try replacing this in font.c: WINE_GCPW_FORCE_RTL:WINE_GCPW_FORCE_LTR change FORCE to LOOSE, it should work t

Re: Total bidi regression

2007-09-26 Thread Shachar Shemesh
Maarten Lankhorst wrote: > Shachar Shemesh schreef: > >> Maarten Lankhorst wrote: >> >> >>> If you want it back try replacing this in font.c: >>> WINE_GCPW_FORCE_RTL:WINE_GCPW_FORCE_LTR >>> change FORCE to LOOSE, it should work then. >>> >>> >> I'm not sure what you are sugge

Re: Total bidi regression

2007-09-26 Thread Maarten Lankhorst
Shachar Shemesh schreef: > Maarten Lankhorst wrote: > >> If you want it back try replacing this in font.c: >> WINE_GCPW_FORCE_RTL:WINE_GCPW_FORCE_LTR >> change FORCE to LOOSE, it should work then. >> > I'm not sure what you are suggesting. > > WINE_GCPW_FORCE_RTL only appear on line 1089 of

Re: Total bidi regression

2007-09-26 Thread Shachar Shemesh
Maarten Lankhorst wrote: > > If you want it back try replacing this in font.c: > WINE_GCPW_FORCE_RTL:WINE_GCPW_FORCE_LTR > change FORCE to LOOSE, it should work then. > I'm not sure what you are suggesting. WINE_GCPW_FORCE_RTL only appear on line 1089 of bidi.c, which reads: >case WINE_GCP

Re: Total bidi regression

2007-09-26 Thread Maarten Lankhorst
Shachar Shemesh schreef: > Hi Maarten, > > It seems that since your last changes to the Bidi implementation, BiDi > suffered total regression. At least on my system, no BiDi related text > (neither Hebrew nor Arabic) gets reordered, at all. Placing breakpoints > suggest that BIDI_Reorder is still g

Total bidi regression

2007-09-26 Thread Shachar Shemesh
Hi Maarten, It seems that since your last changes to the Bidi implementation, BiDi suffered total regression. At least on my system, no BiDi related text (neither Hebrew nor Arabic) gets reordered, at all. Placing breakpoints suggest that BIDI_Reorder is still getting called, so I can only assume