Uninstaller: 2 questions

2007-04-25 Thread Tom Spear
Why do we show a dialog if there are no uninstall entries found in the registry? Windows does not do that, and I think we shouldn't either. However, on that same note, I think we should, since this uninstaller is not designed to mimic Windows' Add/Remove Programs, catch when a program's

Re: Uninstaller: 2 questions

2007-04-25 Thread Steven Edwards
Hi Tom, I've watched your discussions for a while and have been meaning to comment but have been super busy. The uninstaller was one of the first things I looked at when getting in to wine development and it confused me to no end due to a bug that only showed up when running it under windows.

Re: Uninstaller: 2 questions

2007-04-25 Thread Frank Richter
On 25.04.2007 19:58, Steven Edwards wrote: Why do we show a dialog if there are no uninstall entries found in the registry? Windows does not do that, and I think we shouldn't either. I agree. So a user starts the uninstall app but doesn't see a dialog... and probably thinks it's a bug. On

Re: Uninstaller: 2 questions

2007-04-25 Thread Tom Spear
On 4/25/07, Steven Edwards [EMAIL PROTECTED] wrote: Hi Tom, I've watched your discussions for a while and have been meaning to comment but have been super busy. The uninstaller was one of the first things I looked at when getting in to wine development and it confused me to no end due to a bug

Re: Uninstaller: 2 questions

2007-04-25 Thread Tom Spear
On 4/25/07, Frank Richter [EMAIL PROTECTED] wrote: So a user starts the uninstall app but doesn't see a dialog... and probably thinks it's a bug. On the other hand, just showing a dialog with an empty list makes it clear that there's nothing to uninstall and will probably not produce false bug

Re: Uninstaller: 2 questions

2007-04-25 Thread Steven Edwards
On 4/25/07, Tom Spear [EMAIL PROTECTED] wrote: I assume, then, that you have since fixed it? If not, I'd like to take a stab. Someone fixed it a while back. I don't know what the cause of the original bug was. When your done with your testing if you don't mind and have MSVC or a mingw

Re: Uninstaller: 2 questions

2007-04-25 Thread Robert Shearman
Tom Spear wrote: However, on that same note, I think we should, since this uninstaller is not designed to mimic Windows' Add/Remove Programs, catch when a program's uninstaller does not remove it's uninstall entry from the registry, after the process exits, and go ahead and remove the entry.

Re: Uninstaller: 2 questions

2007-04-25 Thread Tom Spear
On 4/25/07, Robert Shearman [EMAIL PROTECTED] wrote: What happens if you cancel the uninstall? Won't the uninstaller remove the entry with the program still installed? That is true too. I was originally thinking along the lines of checking the exit status of the uninstaller, but whether it is