Jacek Caban [EMAIL PROTECTED] wrote:
@@ -310,15 +335,24 @@ static void intern_atoms(void)
names = HeapAlloc( GetProcessHeap(), 0, count * sizeof(*names) );
atoms = HeapAlloc( GetProcessHeap(), 0, count * sizeof(*atoms) );
-for (format = ClipFormats, i = 0; format; format =
It appears that Mike has been doing a lot of work on this.
http://www.winehq.org/hypermail/wine-devel/2004/09/0221.html
So you probably first want to coordinate with him.
Yes. I'm aware that I'm holding people up right now due to my
non-connectedness. I'm actually living in a bedbreakfast with no
Joris Huizer wrote:
Fine by me ;) where do I start then.. I can't find much on the winehq
site about that (I found a http://sourceforge.net/projects/winecfg/ but
it seems the last update was over a year ago..)
What's there to do, how to... etc - kind find much documentation except
for the fact
Duane Clark wrote:
Mike Hearn wrote:
If you're just generally looking for things to do, W-A cleanup isn't
the only task. You could help extend the test suite :)
Or another possibility... since there is no longer a ~/.wine/config file
installed, we really, really need some serious work on
On Fri, Sep 10, 2004 at 08:19:09PM +0200, Joris Huizer wrote:
site about that (I found a http://sourceforge.net/projects/winecfg/ but
it seems the last update was over a year ago..)
What's there to do, how to... etc - kind find much documentation except
for the fact it's mentioned as a Todo
James Hawkins wrote:
However, I don't know how to make simple tests.. as I'd really need to
test wether the code I write works, and works properly :p
The best way to test the functionality of a certain api function
against windows is to read the msdn docs on that function. There are
certain easy
So -- is there a unit testing or so or do all people just make a bunch
of extra files to make the function calls and make what they need compile?
If I change, say , dlls/winmm/mci.c: winmm: mciSendStringW , how will I
be able to verify the change didn't change the behavior of the function?
Mike Hearn wrote:
If you're just generally looking for things to do, W-A cleanup isn't
the only task. You could help extend the test suite :)
Or another possibility... since there is no longer a ~/.wine/config file
installed, we really, really need some serious work on winecfg. That
should be
?
(rather than just trusting I am sort-of sure my hacks are working??)
as a side note, changing the W-A calls for mciSendStringW only makes
sense when the MCI drivers (at least the 32 bit ones) are ported to
unicode interface (which another magnitude of effort than just the
mciSendStringW function).
A+
give some clues on that; I found there are many W-A
calls in dlls/winmm/winmm.c (according to the janitorial page) so I
might start there (hoping not all of them are so tricky ;) )
Thanks for suggestions on this,
Joris
you can give some clues on that; I found there are many W-A
calls in dlls/winmm/winmm.c (according to the janitorial page) so I
might start there (hoping not all of them are so tricky ;) )
Thanks for suggestions on this,
Joris
--
James Hawkins
a month ago, I saw a thread, including an interesting patch, about
the W-A calls; Could someone find that link? Are there
tutorials/manuals/guides/... about Unicode funcitons you recommend ?
Now, on to the work: if you can hand me that thread, how do I start? Are
there unit tests? Where should
Joris Huizer wrote:
Hello,
I'm thinking of trying to do some helpfull work on wine;
Cool!
I have the following problem,
- I don't know where to start (I have never done stuff in wine or
another open source project) ; but I hope you have patience to guide me
into that (but I'm a informatica
Hey Joris,
I started developing wine in exactly the same way you are
starting: working on the janitorial projects. My current project is
converting the crypt cross calls, and it is almost finished, but im
waiting for my CryptSetProviderExA patch to be committed before I send
the rest of my
Le mer 25/08/2004 à 11:27, Joris Huizer a écrit :
[snip]
Hi James,
Yeah I would like that, thanks for suggesting :)
I'll try and do a search on unicode functions and stuff but -- well, you
have seen more of wine specific details ...
Also, I think it'd be smart to put something like that
Hey Joris, I would be glad to write a howto for your and possibly
others. I will get started on that soon.
On 25 Aug 2004 11:43:57 -0400, Vincent Béron
[EMAIL PROTECTED] wrote:
Le mer 25/08/2004 à 11:27, Joris Huizer a écrit :
[snip]
Hi James,
Yeah I would like that, thanks for
I have compiled crypt and run the tests with no failures.
This latest patch removes all changes to the pointer arithmetic.
On Tue, 03 Aug 2004 07:55:51 +0300, Shachar Shemesh
[EMAIL PROTECTED] wrote:
James Hawkins wrote:
- strcpy(keyname + strlen(KEYSTR), pProvName);
I
James Hawkins [EMAIL PROTECTED] wrote:
Full rewrite. If you have any questions, I'll be happy to answer them.
Changelog
* clean up cross-call functions
- strcpy(keyname, KEYSTR);
- strcpy(keyname + strlen(KEYSTR), pProvName);
+ strcpyW(keyname, KEYSTR);
+ strcpyW(keyname +
James Hawkins wrote:
+PWSTR keyname;
- keyname = CRYPT_Alloc(strlen(KEYSTR) + strlen(pProvName) +1);
+keyname = CRYPT_Alloc((strlenW(KEYSTR) + strlenW(pProvName) + 1) *
sizeof(WCHAR));
if (keyname)
{
- strcpy(keyname, KEYSTR);
-
- strcpy(keyname + strlen(KEYSTR), pProvName);
I changed that line to strcatW(keyname, pProvName). That makes a lot
more sense Mike, thanks for the tip.
I'm wasn't exactly sure on this one so it would be great if you could
help me on this one. When using pointer arithmetic, do the
James Hawkins [EMAIL PROTECTED] wrote:
ptr = keyname + strlenW(keyname);
I guess it holds true here as well because keyname is a pointer and
we're adding ot it. If that is the case, the included patch fixes the
two things mentioned.
You have to look for other similar, not mentioned cases,
James Hawkins wrote:
- strcpy(keyname + strlen(KEYSTR), pProvName);
I changed that line to strcatW(keyname, pProvName). That makes a lot
more sense Mike, thanks for the tip.
I'm wasn't exactly sure on this one so it would be great if you could
help me on this one. When using
James Hawkins [EMAIL PROTECTED] wrote:
This is a resubmit of my original patch that cleans up a-w cross
calls in crypt.
Changelog
* cleanup a-w cross calls in advapi32/crypt.c
+ static const WCHAR KEYSTR[] = {
+ 'S','o','f','t','w','a','r','e','\\','\\',
+ 'M','i','c','r
James Hawkins [EMAIL PROTECTED] writes:
- PCSTR KEYSTR = Software\\Microsoft\\Cryptography\\Defaults\\Provider\\;
- PSTR keyname;
+ PCWSTR KEYSTR =
(PCWSTR)Software\\Microsoft\\Cryptography\\Defaults\\Provider\\;
+ PWSTR keyname;
This is wrong, you need to declare Unicode
K i will use A-W calls. What documentation are you referring to?
I'd like to read up on the subject.
James Hawkins
On Wed, 30 Jun 2004 07:00:58 -0700 (PDT), Steven Edwards
[EMAIL PROTECTED] wrote:
Hi James,
--- James Hawkins [EMAIL PROTECTED] wrote:
If I'm totally off the mark, let me
have chosen menial tasks to take on.
This way I can learn more about Wine while contributing.
I am currently working on the janitorial task of getting rid of W-A
calls and I have a few questions about how I should implement these
changes.
Initially CryptAcquireContextW converts all of its
to take on.
This way I can learn more about Wine while contributing.
I am currently working on the janitorial task of getting rid of W-A
calls and I have a few questions about how I should implement these
changes.
Initially CryptAcquireContextW converts all of its arguments to ansi
I recently decided to help with the development of Wine, and seeing as
how I am new to the process, I have chosen menial tasks to take on.
This way I can learn more about Wine while contributing.
I am currently working on the janitorial task of getting rid of W-A
calls and I have a few
.
Em Sáb 10 Jan 2004 04:51, Marcelo Duarte escreveu:
Updated with the lastest cvs.
Changelog:
Marcelo Duarte [EMAIL PROTECTED]
-Janitorial: Get rid of W-A calls for shlexec
-Implementation of FindExecutableW
--
Marcelo Duarte
Marcelo Duarte [EMAIL PROTECTED] writes:
Hi,
Changelog:
Marcelo Duarte [EMAIL PROTECTED]
-Janitorial: Get rid of W-A calls for shlexec
-Implementation of FindExecutableW
Coments:
After you aplying my patch 1/2 and made corrections using sizeof, I see the
problems in the patch 2/2 and I
Not 100% about the part changing METAHEADERDISK.filename type. Can apps
access it directly and barf if they find WCHAR instead of CHAR? And is
the length set to 0x100 for binary compatibility?
Changelog:
Get rid of W-A calls for metafiles.
Vincent
Index: dlls/gdi/mfdrv/init.c
ASCII, I'd suggest
keeping the encoding of strings inside the message
as ASCII.
Do you mean the conver of lpHelpFile in WinHelpA
before it calls WinHelpW?
p.s. sorry I didn't find time for this doing the week
Hatky.
__
Do you Yahoo!?
Yahoo! SiteBuilder -
On Fri, 12 Sep 2003, hatky wrote:
Do you mean the conver of lpHelpFile in WinHelpA
before it calls WinHelpW?
It means that somehow you picked another tricky
example to work on :) WinHelp is a very special
API in that it does some fucky/ugly stuff to
pass data between apps.
I'd do another one
Janitorial reporting ;-)
In the Get rid of W-A calls task,
Say I try
dlls/ddraw/main.c: ddraw: DirectDrawEnumerateExW:
illegal call to DirectDrawEnumerateExA
The misbheaving function is :
HRESULT WINAPI DirectDrawEnumerateExW(
LPDDENUMCALLBACKEXW lpCallback, LPVOID lpContext,
DWORD dwFlags
Because I'm a lousy teacher :) Also, it is more
productive
to start with simpler examples, so you also do part
of the
learning from experience.
grr.
Ok, lets take another one, winhelp.c WinHelpW-A
I take whatever is in WinHelpA and move it into
WinHelpW with the fallowing changes:
35 matches
Mail list logo