Re: XEmbed Systray Support

2005-11-10 Thread Vijay Kiran Kamuju
Thereis one more thing, i still see a minimized window just above the panel, i think that should go. Its in Gnome i dont know how its in other WM's bye, Vijay On 11/10/05, James Liggett [EMAIL PROTECTED] wrote: On Thu, 2005-11-10 at 11:32 +0530, Vijay Kiran Kamuju wrote: I have to Julliard

Re: XEmbed Systray Support

2005-11-09 Thread James Liggett
Ok I created some new patches. (I decided to break it up this time. They can be applied in any order) Thanks for helping test this! :) If you have any feedback, please let me know...If they work out OK I will post them to wine-patches again. James On Wed, 2005-11-09 at 11:07 +0530, Vijay Kiran

Re: XEmbed Systray Support

2005-11-09 Thread James Liggett
On Wed, 2005-11-09 at 15:26 +0530, Vijay Kiran Kamuju wrote: I have tested googletalk with the patch of yours, i am attaching the screenshot of it. whenever i ve closed an googletalk instance its present on the screen (in the picture i have labelled it as zombie), in ps -ef its not killing

Re: XEmbed Systray Support

2005-11-09 Thread Vijay Kiran Kamuju
I have to Julliard regarding this, he still thinks that there should be some more work to be done on it. He did not mentioned what work is to be done. Well you should also see that if any one closes a systray application, any wine process should not be present after closing the app. Please check

Re: XEmbed Systray Support

2005-11-09 Thread James Liggett
On Thu, 2005-11-10 at 11:32 +0530, Vijay Kiran Kamuju wrote: I have to Julliard regarding this, he still thinks that there should be some more work to be done on it. He did not mentioned what work is to be done. Yeah, I have as well. He's yet to return my e-mail on that one. Well you should

Re: XEmbed Systray Support

2005-11-08 Thread Vijay Kiran Kamuju
could you please send a new patch as per latest cvs or 0.9 I would like to test this patch. with 0.9 its not applying properly Thanks, Vijay On 10/27/05, James Liggett [EMAIL PROTECTED] wrote: On Wed, 2005-10-19 at 14:33 +0200, Alexandre Julliard wrote: I'm afraid it's too big a change to get

Re: XEmbed Systray Support

2005-10-26 Thread James Liggett
On Wed, 2005-10-19 at 14:33 +0200, Alexandre Julliard wrote: I'm afraid it's too big a change to get in at this point. Besides, there are still problems with that patch. Now that 0.9 is released and the freeze is over, can you please tell me what the problems are so I can fix them? Thanks,

Re: XEmbed Systray Support

2005-10-19 Thread Alexandre Julliard
Jonathan Ernst [EMAIL PROTECTED] writes: http://bugs.winehq.org/show_bug.cgi?id=1301 is in Wine 0.9 blocker list. I guess this patch should go in before Wine 0.9 is released. (same goes for finalizing the docs); isn't it ? I'm afraid it's too big a change to get in at this point. Besides,

Re: XEmbed Systray Support

2005-10-19 Thread James Liggett
I'm afraid it's too big a change to get in at this point. Besides, there are still problems with that patch. Which problems are you referring to? It's true that there are some issues with it, but those (at least in my testing anyway) are limited to Gnome. With other desktops, such as XFce and

Re: XEmbed Systray Support

2005-10-18 Thread James Liggett
Anything wrong with this patch? (Resent version) James Liggett On Tue, 2005-10-11 at 17:07 -0700, James Liggett wrote: Hi, This patch implements XEmbed system tray support for recent non-KDE desktops. This is a modified version of a patch originally submitted by Rob Shearman, [EMAIL

Re: XEmbed Systray Support

2005-10-18 Thread James Hawkins
On 10/18/05, James Liggett [EMAIL PROTECTED] wrote: Anything wrong with this patch? (Resent version) We're in a feature freeze right now till 0.9 is released. I would try submitting again after that point. -- James Hawkins

Re: XEmbed Systray Support

2005-10-18 Thread James Liggett
On Tue, 2005-10-18 at 15:05 -0500, James Hawkins wrote: On 10/18/05, James Liggett [EMAIL PROTECTED] wrote: Anything wrong with this patch? (Resent version) We're in a feature freeze right now till 0.9 is released. I would try submitting again after that point. Ok, thanks. I wasn't sure

Re: XEmbed Systray Support

2005-10-18 Thread James Hawkins
On 10/18/05, James Liggett [EMAIL PROTECTED] wrote: Ok, thanks. I wasn't sure that this would be affected by the freeze, since this functionality is on the task list for 0.9. I thought I would try to get it in since it's a major usability problem for anyone who uses anything other than KDE.

Re: XEmbed Systray Support

2005-10-18 Thread James Hawkins
On 10/18/05, Jonathan Ernst [EMAIL PROTECTED] wrote: http://bugs.winehq.org/show_bug.cgi?id=1301 is in Wine 0.9 blocker list. I guess this patch should go in before Wine 0.9 is released. (same goes for finalizing the docs); isn't it ? If you look at this as a bug, then it's possible

Re: XEmbed Systray Support

2005-09-23 Thread James Liggett
On Wed, 2005-09-21 at 12:07 +0200, Alexandre Julliard wrote: Also what's the reason for having an XSync here? The XSync call is in the example on freedeskotop.org for showing how to send client messages (http://standards.freedesktop.org/systemtray-spec/systemtray-spec-0.2.html#messages) uses

Re: XEmbed Systray Support

2005-09-21 Thread Alexandre Julliard
Robert Shearman [EMAIL PROTECTED] writes: +ev.xclient.type = ClientMessage; +ev.xclient.window = systray_window; +ev.xclient.message_type = x11drv_atom(_NET_SYSTEM_TRAY_OPCODE); +ev.xclient.format = 32; +ev.xclient.data.l[0] = CurrentTime; +

Re: XEmbed Systray Support

2005-09-21 Thread Robert Shearman
Alexandre Julliard wrote: Robert Shearman [EMAIL PROTECTED] writes: +ev.xclient.type = ClientMessage; +ev.xclient.window = systray_window; +ev.xclient.message_type = x11drv_atom(_NET_SYSTEM_TRAY_OPCODE); +ev.xclient.format = 32; +ev.xclient.data.l[0]

Re: XEmbed Systray Support

2005-09-21 Thread Alexandre Julliard
Robert Shearman [EMAIL PROTECTED] writes: I've added the locking. The XSync is needed because without it the systray window ends up with a width of 1. I don't understand why this is happening. What debug channels would be good to turn on to investigate this? Probably +event and check for

Re: XEmbed Systray Support

2005-09-21 Thread James Liggett
Adding the locking fixes the problem about icons not docking properly that I described in one of my posts yesterday. It's much better now. James On Wed, 2005-09-21 at 13:58 -0500, Robert Shearman wrote: Alexandre Julliard wrote: Robert Shearman [EMAIL PROTECTED] writes: +

Re: XEmbed Systray Support

2005-09-20 Thread Robert Shearman
Robert Shearman wrote: Hi, This patch allows new non-KDE systems to display notification area icons for Win32 apps in the window manager's system tray, instead of in a 16x16 top-level window. Changelog: Support XEmbed protocol for system tray windows. Anything wrong with this patch? --

Re: XEmbed Systray Support

2005-09-20 Thread James Liggett
Aside from the bugs I've mentioned before, it doesn't seem that the implementation of this works quite right. This patch should address the bugs in dlls/shell32/systray.c, not just the docking. I've fixed most things, but there is still one big problem. There's a window cleanup problem where the

Re: XEmbed Systray Support

2005-09-17 Thread Rob Shearman
Robert Shearman wrote: Hi, This patch allows new non-KDE systems to display notification area icons for Win32 apps in the window manager's system tray, instead of in a 16x16 top-level window. Changelog: Support XEmbed protocol for system tray windows. Sorry, I forgot to credit Mike