Re: bogus patch to bind() dlls/winsock/socket.c (request removal)

2004-01-11 Thread Mike Hearn
That looks familiar. In fact, the TRACE was originally a FIXME but it caused so much spew with so many apps I changed it. I couldn't see exactly what needed to be fixed given the contents of the message - it seems to be simply informing us of progress, but it's a possibility somebody knew this

Re: bogus patch to bind() dlls/winsock/socket.c (request removal)

2004-01-11 Thread Christoph Frick
On Sun, Jan 11, 2004 at 12:36:46PM +, Mike Hearn wrote: -/* The game GrandPrixLegends binds more than one time, but does - * not do a SO_REUSEADDR - Stevens says this is ok */ -TRACE( Setting WS_SO_REUSEADDR on socket before we bind

Re: bogus patch to bind() dlls/winsock/socket.c (request removal)

2004-01-11 Thread Alexandre Julliard
Jeremy White [EMAIL PROTECTED] writes: It's been years since I was a Stevens expert, but there was a day when I was, and my gut reaction to that patch was one of shuddering horror. In fact, I really should argue for the complete reversal of the patch until a regression test can conclusively

Re: bogus patch to bind() dlls/winsock/socket.c (request removal)

2004-01-11 Thread Jeremy White
Well, the patch apparently helps in some cases and hurts in others, so the only way to decide is to write a test and determine what the exact behavior is under Windows. I agree the current behavior looks wrong, but that doesn't mean anything when dealing with Microsoft code... A quick foo.c shows

Re: bogus patch to bind() dlls/winsock/socket.c (request removal)

2004-01-10 Thread Jeremy White
Jeremy Shaw wrote: As a result of this patch (which is currently applied in cvs head): http://www.winehq.com/hypermail/wine-patches/2002/12/0009.html This also makes the Quicktime player unable to view streaming video, although I have to confess I do not know why, except that the bind failure

Re: bogus patch to bind() dlls/winsock/socket.c (request removal)

2004-01-10 Thread Ivan Leo Murray-Smith
With this change, we can use the 6.3 version of Quicktime to see streamed video from Wineconf... This would break Grand Prix Legends and Nascar 2002 (Thats why the patch was written in the first place), maybe you should contact the author of the patch, a proper fix would be better, why should we

Re: bogus patch to bind() dlls/winsock/socket.c (request removal)

2004-01-10 Thread Daniel Kegel
Ivan Leo Murray-Smith wrote: With this change, we can use the 6.3 version of Quicktime to see streamed video from Wineconf... This would break Grand Prix Legends and Nascar 2002 (Thats why the patch was written in the first place), maybe you should contact the author of the patch, a proper fix

bogus patch to bind() dlls/winsock/socket.c (request removal)

2004-01-08 Thread Jeremy Shaw
As a result of this patch (which is currently applied in cvs head): http://www.winehq.com/hypermail/wine-patches/2002/12/0009.html WS_bind() currently does this before every call to bind(): WS_setsockopt( s, WS_SOL_SOCKET, WS_SO_REUSEADDR, (char*)on, sizeof(on) ); Basically, it sets