Re: cabinet: Fix NULL pointer dereference (Coverity)

2006-09-26 Thread James Hawkins
On 9/26/06, Andrew Talbot [EMAIL PROTECTED] wrote: Changelog: cabinet: Fix NULL pointer dereference (Coverity). diff -urN a/dlls/cabinet/fci.c b/dlls/cabinet/fci.c --- a/dlls/cabinet/fci.c2006-09-12 23:59:28.0 +0100 +++ b/dlls/cabinet/fci.c2006-09-26 18:27

Re: cabinet: Fix NULL pointer dereference (Coverity)

2006-09-26 Thread Andrew Talbot
This last check is pointless. If perf is NULL, we bail out and return NULL a few lines up. Also, please add a test showing that native does not crash if a NULL perf is sent in. It's weird, but we need to be consistent with native, as some apps depend on such a crash. Whoops! Thanks,