Re: comctl32/test: test CheckState Macros

2009-05-08 Thread Vitaliy Margolen
André Hentschel wrote: I made one patch out of them and improved my tests. now i wonder again why its not getting in... You should use SNDMSGW. Vitaliy.

Re: comctl32/test: test CheckState Macros

2009-05-08 Thread Nikolay Sivov
Vitaliy Margolen wrote: André Hentschel wrote: I made one patch out of them and improved my tests. now i wonder again why its not getting in... You should use SNDMSGW. Vitaliy. No actually. Native uses ListView_SetItemState for that macro which is SNDMSGA in wine and SNDMSG in

Re: comctl32/test: test CheckState Macros

2009-05-08 Thread Vitaliy Margolen
Nikolay Sivov wrote: No actually. Native uses ListView_SetItemState for that macro which is SNDMSGA in wine and SNDMSG in native. He asked why his patch is not getting in - that's one of the reasons. You should always use SendMessageW where possible. Especially for things that don't care if it's

Re: comctl32/test: test CheckState Macros

2009-05-07 Thread André Hentschel
Austin English schrieb: 2009/5/5 André Hentschel n...@dawncrow.de: --- dlls/comctl32/tests/listview.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) This patch fails without your other patch. In the future, please combine them into one patch, or number them in a series.

Re: comctl32/test: test CheckState Macros

2009-05-05 Thread Austin English
2009/5/5 André Hentschel n...@dawncrow.de: ---  dlls/comctl32/tests/listview.c |    2 ++  1 files changed, 2 insertions(+), 0 deletions(-) This patch fails without your other patch. In the future, please combine them into one patch, or number them in a series. Wine must compile and pass the