Re: comctl32: Fix bitmap size calculation

2009-03-27 Thread Vitaliy Margolen
Aleksey Bragin wrote: On Mar 27, 2009, at 3:39 AM, Vitaliy Margolen wrote: Yes exactly, however I didn't provide any testcase, because I just removed non-used parameter and fixed existing code. If someone wants to implement image list having variable width of each image - he's free to proof

Re: comctl32: Fix bitmap size calculation

2009-03-27 Thread MikoĊ‚aj Zalewski
Anyway, e.g. Sib Icon Edit required ~ 30 Mb (something like 27 images * 13440 width * 24 height * sizeof(each pixel)) of memory for every instance to run (due to this bug). Now it requires only about 300kb Fixing one app doesn't mean it's correct. Yes, there is an obvious error in the

Re: comctl32: Fix bitmap size calculation

2009-03-27 Thread Aleksey Bragin
On Mar 27, 2009, at 3:39 AM, Vitaliy Margolen wrote: Aleksey Bragin wrote: Fix bitmap size calculation in IMAGELIST_InternalExpandBitmaps and remove unneded parameter. Memory requirements are greatly reduced after this fix. The bug was an ambiguous meaning of a cx parameter, which was

Re: comctl32: Fix bitmap size calculation

2009-03-27 Thread Aleksey Bragin
On Mar 27, 2009, at 6:47 PM, Vitaliy Margolen wrote: Anyway, e.g. Sib Icon Edit required ~ 30 Mb (something like 27 images * 13440 width * 24 height * sizeof(each pixel)) of memory for every instance to run (due to this bug). Now it requires only about 300kb Fixing one app doesn't mean

Re: comctl32: Fix bitmap size calculation

2009-03-26 Thread Vitaliy Margolen
Aleksey Bragin wrote: Fix bitmap size calculation in IMAGELIST_InternalExpandBitmaps and remove unneded parameter. Memory requirements are greatly reduced after this fix. The bug was an ambiguous meaning of a cx parameter, which was supposed to be a width of an individual image inside the