const cleanup round 1(commentary on what I found)

2007-03-13 Thread Mike Schaadt
Some of this was included in the patch submission. Some of it I had questions about. spawn.c : warnings may or may not be harmless depending on if esecvp attempts to modify the results. Specs indicate it doesn't, but the function typing doesn't indicate so(the difference is 'const char * const

Re: const cleanup round 1

2007-03-13 Thread Mike Schaadt
after some extra testing I found that it's not that my modification would forbid that, but it would complain about the second parameter not being const(which I thought that the compiler would be fine with auto promoting the WCHAR ** to const WCHAR **). Fair enoug then. Strike those

Re: const cleanup round 1

2007-03-13 Thread Eric Pouech
Mike Schaadt a écrit : after some extra testing I found that it's not that my modification would forbid that, but it would complain about the second parameter not being const(which I thought that the compiler would be fine with auto promoting the WCHAR ** to const WCHAR **). Fair enoug then.