> The calls or the definitions?
> If the definition, should I move is_quotable_char too?
The definitions. Yes, please.
--Juan
Am 2011-01-11 17:11, schrieb Juan Lang:
> Also, since CertRDNValueToStr doesn't need quote_string, you should
> probably invert the order in which they appear in the file.
The calls or the definitions?
If the definition, should I move is_quotable_char too?
--Christian
Hi Christian,
on second thought I don't have too much to say about this, other than
style comments: take them or leave them.
+/* Only use this function internally. */
This comment isn't all that useful. You might indicate that quotes
are only needed by CertNameToStr when the string type is
CERT_
Am 2011-01-11 00:02, schrieb Juan Lang:
> Hi Christian,
hi,
> Adding tests that demonstrate that would help a great deal.
I've sended my patches, they look a little bit weird, but they work.
> Don't use Hungarian notation for internal functions, it's hard to
> distinguish them from Win32 API functi
Hi Christian,
> As tested on Windows(R) 7 Home Premium x64, "CertRDNValueToStr" Doesn't
> handle the quoting.
> Instead it's made on "CertNameToStr" with CERT_X500_NAME_STR flag.
Adding tests that demonstrate that would help a great deal.
A minor comment regarding the patch itself:
+/* Only use
