Re: d3d [8]: Remove AddRef from IWineD3D*_QueryInterface. This also removes the implicit AddRef in IWineD3D*_GetContainer.

2006-11-28 Thread Stefan Dösinger
Am Dienstag 28 November 2006 13:18 schrieben Sie: > Stefan Dösinger wrote: > > Am Dienstag 28 November 2006 00:48 schrieb H. Verbeet: > >> I thought we discussed on IRC why this is a bad idea? Anyway, you > >> can't do this. Removing the AddRef in QueryInterface is a pretty > >> blatant violation o

Re: d3d [8]: Remove AddRef from IWineD3D*_QueryInterface. This also removes the implicit AddRef in IWineD3D*_GetContainer.

2006-11-28 Thread Robert Shearman
Stefan Dösinger wrote: Am Dienstag 28 November 2006 00:48 schrieb H. Verbeet: I thought we discussed on IRC why this is a bad idea? Anyway, you can't do this. Removing the AddRef in QueryInterface is a pretty blatant violation of COM specs, and is pretty sure to cause problems somewhere. The

Re: d3d [8]: Remove AddRef from IWineD3D*_QueryInterface. This also removes the implicit AddRef in IWineD3D*_GetContainer.

2006-11-28 Thread Stefan Dösinger
Am Dienstag 28 November 2006 00:48 schrieb H. Verbeet: > I thought we discussed on IRC why this is a bad idea? Anyway, you > can't do this. Removing the AddRef in QueryInterface is a pretty > blatant violation of COM specs, and is pretty sure to cause problems > somewhere. The caller of that functi

Re: d3d [8]: Remove AddRef from IWineD3D*_QueryInterface. This also removes the implicit AddRef in IWineD3D*_GetContainer.

2006-11-27 Thread H. Verbeet
I thought we discussed on IRC why this is a bad idea? Anyway, you can't do this. Removing the AddRef in QueryInterface is a pretty blatant violation of COM specs, and is pretty sure to cause problems somewhere. The caller of that function won't always know if the object it's called on is a wined3d