Re: d3dx9_36: Push down the scope of two variables. (RESEND)

2011-07-10 Thread Gerald Pfeifer
On Tue, 5 Jul 2011, Alexandre Julliard wrote: >> This does not fix a bug or add a feature, but it makes the coder easier >> to follow. Narrower scope tends to be a good thing for variables, both >> for human readers and compilers (though modern ones should not need the >> hint). > Not necessarily,

Re: d3dx9_36: Push down the scope of two variables. (RESEND)

2011-07-05 Thread Henri Verbeet
I think the point is more that (in general) this kind of patch is unlikely to be accepted unless you're actively maintaining the code.

Re: d3dx9_36: Push down the scope of two variables. (RESEND)

2011-07-05 Thread Tony Wasserka
Am 05.07.2011 20:33, schrieb Gerald Pfeifer: On Tue, 5 Jul 2011, Alexandre Julliard wrote: This does not fix a bug or add a feature, but it makes the coder easier to follow. Narrower scope tends to be a good thing for variables, both for human readers and compilers (though modern ones should no

Re: d3dx9_36: Push down the scope of two variables. (RESEND)

2011-07-05 Thread Alexandre Julliard
Gerald Pfeifer writes: > This does not fix a bug or add a feature, but it makes the coder easier > to follow. Narrower scope tends to be a good thing for variables, both > for human readers and compilers (though modern ones should not need the > hint). Not necessarily, that's a matter of taste