Re: ddeml: More calling convention fixes

2010-12-02 Thread Dmitry Timoshkov
Tristan Schmelcher wrote: > I think CBR_BLOCK is only for values of type HDDEDATA. The cbData > value here is a DWORD (specifying a length). (DWORD)-1 seems to be the > preferred way of checking this condition in the existing code, e.g. > see dlls/user32/dde_client.c lines 637, 648, etc. You are

Re: ddeml: More calling convention fixes

2010-12-02 Thread Tristan Schmelcher
I think CBR_BLOCK is only for values of type HDDEDATA. The cbData value here is a DWORD (specifying a length). (DWORD)-1 seems to be the preferred way of checking this condition in the existing code, e.g. see dlls/user32/dde_client.c lines 637, 648, etc. I will re-send the patch in two parts. On

Re: ddeml: More calling convention fixes

2010-12-02 Thread Dmitry Timoshkov
Tristan Schmelcher wrote: > +if (cbData != (DWORD)-1) > +{ > +/* pData is not a pointer if cbData is -1, so we linearize the > address > + * here rather than in the calling code. */ > +pData = MapSL((SEGPTR)pData); > +} -1 here should be replaced by CBR_BLOCK