Re: ddraw:d3d tests failing consistently

2007-10-27 Thread Francois Gouget
On Sat, 27 Oct 2007, Stefan Dösinger wrote: [...] If you look at various game boxes in the software shop next to you, you will very often find notes like Works on ATI radeon and Nvidia geforce cards. Mobile versions of the cards are unsupported. Means, that if you have a Destop radeon or gf

Re: ddraw:d3d tests failing consistently

2007-10-27 Thread Stefan Dösinger
Am Samstag, 27. Oktober 2007 21:07:59 schrieb Francois Gouget: If the game fails on Windows, users will either blame the game maker or Intel. We don't care. However if it fails in Wine, the user will blame Wine, not Intel, and not the game maker. Yes, that is the point. Was he talking about

Re: ddraw:d3d tests failing consistently

2007-10-27 Thread H. Verbeet
On 27/10/2007, Francois Gouget [EMAIL PROTECTED] wrote: [...] I don't think the caps will really be useful here, but we could retrieve the card and driver name, and skip the test for some combinations. IDirect3D9::GetAdapterIdentifier() for example should return enough information for

Re: ddraw:d3d tests failing consistently

2007-10-27 Thread Jakob Eriksson
Francois Gouget wrote: It seems what you want is unit tests that would garantee that WineD3D behaves in the way which _you_ have decided. Most of the time that's the same as writing a _conformance_ test, but apparently in this specific case it's different. If that's so, then maybe we have

Re: ddraw:d3d tests failing consistently

2007-10-26 Thread Reece Dunn
On 26/10/2007, Stefan Dösinger [EMAIL PROTECTED] wrote: Am Freitag, 26. Oktober 2007 01:22:22 schrieb Reece Dunn: Also, I suspect that it would be worth adding vmware in the test cases. That is, something like: ok( ret == 129 /* Windows */ || ret == 133 /* VMware */, ... ); This

Re: ddraw:d3d tests failing consistently

2007-10-26 Thread Francois Gouget
On Fri, 26 Oct 2007, Reece Dunn wrote: [...] This would mean that the tests that are consistently (and predictably) failing under vmware will not show up on the test failures, so we can investigate actual failures. Well, as far as I know, except for Direct3D and maybe sound issues, VMware

Re: ddraw:d3d tests failing consistently

2007-10-26 Thread Stefan Dösinger
Am Freitag, 26. Oktober 2007 15:42:18 schrieb Jakob Eriksson: Agree 100%. Windows on vmware is still Windows. No, I do not agree with that. Using that logic, Windows on Parallels would still be Windows. However, Parallels uses WineD3D as their Direct3D driver. Is Windows on Parallels still

Re: ddraw:d3d tests failing consistently

2007-10-26 Thread Jakob Eriksson
Francois Gouget wrote: acceleration that they added in 6.0. So the relevant tests should be easy to skip, either by detecting lack of any 3D support or in the worst case by detecting the name of the graphics /sound card. Agree 100%. Windows on vmware is still Windows. // Jakob

Re: ddraw:d3d tests failing consistently

2007-10-26 Thread Francois Gouget
On Fri, 26 Oct 2007, Stefan Dösinger wrote: Am Freitag, 26. Oktober 2007 15:42:18 schrieb Jakob Eriksson: Agree 100%. Windows on vmware is still Windows. No, I do not agree with that. Using that logic, Windows on Parallels would still be Windows. However, Parallels uses WineD3D as their

Re: ddraw:d3d tests failing consistently

2007-10-26 Thread H. Verbeet
On 26/10/2007, Francois Gouget [EMAIL PROTECTED] wrote: Parallels is a bit of a special case because it does not just replace the graphics driver, but the DirectX dlls altogether. However VMware 5.5 does not do that. In practice the difference isn't that significant. While replacing the

ddraw:d3d tests failing consistently

2007-10-25 Thread Reece Dunn
Hi, Looking at the ddraw:d3d tests, they are failing consistently on many Windows platforms: d3d.c:1039: Test failed: IDirect3DViewport_SetViewport returned 80070057 d3d.c:1050: Test failed: Vertex 2 differs. Got 129.00 127.00 1.00 1.00, expexted 133.00 123.00 1.00

Re: ddraw:d3d tests failing consistently

2007-10-25 Thread Stefan Dösinger
Am Donnerstag, 25. Oktober 2007 22:15:39 schrieb Reece Dunn: Hi, Looking at the ddraw:d3d tests, they are failing consistently on many Windows platforms: Is this a vmware system? signature.asc Description: This is a digitally signed message part.

Re: ddraw:d3d tests failing consistently

2007-10-25 Thread Francois Gouget
On Fri, 26 Oct 2007, Stefan Dösinger wrote: Am Donnerstag, 25. Oktober 2007 22:15:39 schrieb Reece Dunn: Hi, Looking at the ddraw:d3d tests, they are failing consistently on many Windows platforms: Is this a vmware system? At least two of them are (as indicated by their tags), I'm not

Re: ddraw:d3d tests failing consistently

2007-10-25 Thread Stefan Dösinger
Am Freitag, 26. Oktober 2007 01:22:22 schrieb Reece Dunn: Also, I suspect that it would be worth adding vmware in the test cases. That is, something like: ok( ret == 129 /* Windows */ || ret == 133 /* VMware */, ... ); This would mean that the tests that are consistently (and predictably)

Re: ddraw:d3d tests failing consistently

2007-10-25 Thread Reece Dunn
On 25/10/2007, Stefan Dösinger [EMAIL PROTECTED] wrote: Am Donnerstag, 25. Oktober 2007 22:15:39 schrieb Reece Dunn: Hi, Looking at the ddraw:d3d tests, they are failing consistently on many Windows platforms: Is this a vmware system? This is from the

Re: ddraw:d3d tests failing consistently

2007-10-25 Thread Reece Dunn
On 26/10/2007, Francois Gouget [EMAIL PROTECTED] wrote: Would it be possible to gather this kind of information in winetest.exe? Maybe simply grab the name of the graphics card? This would be useful. Also, I suspect that it would be worth adding vmware in the test cases. That is, something

Re: ddraw:d3d tests failing consistently

2007-10-25 Thread Stefan Dösinger
Am Freitag, 26. Oktober 2007 01:54:59 schrieb Reece Dunn: This is true. The tests should only check for valid Windows results. The problem is how to filter out the noise of the VMware bugs from actual failures in Windows for the Wine tests. This is so that we know which tests need fixing (so