Re: dlls/fusion/assembly.c -- no-op error checks

2008-04-16 Thread Gerald Pfeifer
On Wed, 16 Apr 2008, James Hawkins wrote: > Beat ya to the punch :) Better twice than not at all, to paraphrase a German saying. :-) Gerald

Re: dlls/fusion/assembly.c -- no-op error checks

2008-04-16 Thread James Hawkins
On Wed, Apr 16, 2008 at 12:47 PM, Gerald Pfeifer <[EMAIL PROTECTED]> wrote: > On Wed, 16 Apr 2008, James Hawkins wrote: > > The offsets are explicity set to -1 on line 242, so the check needs to > > be for -1. It won't work at all otherwise. > > Thanks, James! I was looking for this, but must

Re: dlls/fusion/assembly.c -- no-op error checks

2008-04-16 Thread James Hawkins
On Wed, Apr 16, 2008 at 9:28 AM, Gerald Pfeifer <[EMAIL PROTECTED]> wrote: > Both offset and tables[].offset are of unsigned types, so these two > checks for errors will never trigger. > The offsets are explicity set to -1 on line 242, so the check needs to be for -1. It won't work at all otherw