Re: dlls/kernel32/path.c: Fix return values for UNC pathnames in GetLongPathNameW

2009-12-01 Thread Alexandre Hardy
Thanks Paul, Right! Tried to implement it too fast! Other parts of the test code dereference the function pointer and I took my lead from there without checking properly. As far as the length goes, I don't really know much about UNC pathnames, so I'm not sure what exactly the result should be. I

Re: dlls/kernel32/path.c: Fix return values for UNC pathnames in GetLongPathNameW

2009-12-01 Thread Paul Vriens
On 12/01/2009 11:52 AM, Paul Vriens wrote: On 12/01/2009 08:44 AM, Alexandre Hardy wrote: + length = (*pGetLongPathNameW)(unc_path,NULL,0); Why the brackets around *pGetLongPathNameW? + ok(length>0,"GetLongPathNameA: Failed on UNC Pathname (length=%d)\n",length); You called the W-function

Re: dlls/kernel32/path.c: Fix return values for UNC pathnames in GetLongPathNameW

2009-12-01 Thread Paul Vriens
On 12/01/2009 08:44 AM, Alexandre Hardy wrote: +length = (*pGetLongPathNameW)(unc_path,NULL,0); Why the brackets around *pGetLongPathNameW? +ok(length>0,"GetLongPathNameA: Failed on UNC Pathname (length=%d)\n",length); You called the W-function so the ok text needs to be adjusted.

Re: dlls/kernel32/path.c: Fix return values for UNC pathnames in GetLongPathNameW

2009-11-28 Thread Paul Vriens
On 11/24/2009 02:41 PM, Alexandre Hardy wrote: The MSDN: http://msdn.microsoft.com/en-us/library/aa364980(VS.85).aspx states that GetLongPathNameW returns the length of the string required to hold the pathname if the buffer is too small to hold the path. In the case where the buffer is too s

dlls/kernel32/path.c: Fix return values for UNC pathnames in GetLongPathNameW

2009-11-25 Thread Alexandre Hardy
The MSDN: http://msdn.microsoft.com/en-us/library/aa364980(VS.85).aspx states that GetLongPathNameW returns the length of the string required to hold the pathname if the buffer is too small to hold the path. In the case where the buffer is too small, the filename should not be stored in the buf