For the record, while I don't think I saw a response to this, the
issue itself was now fixed with basically the same patch submitted
by Marcusso we can remove this from our radars.
Thanks for trying again, Marcus! :-)
Gerald
On Sat, 3 Nov 2007, Gerald Pfeifer wrote:
> Good observation, though co
On Sat, 3 Nov 2007, James Hawkins wrote:
> This change is wrong. If you'd actually read what the code intended to
> do instead of just fixing warnings, you'd see that add_streams_to_table
> returns -1 on error.
That's what I am actually doing -- trying to read the code, including all
invocation
James wrote:
> This change is wrong. If you'd actually read what the code intended
> to do instead of just fixing warnings, you'd see that
> add_streams_to_table returns -1 on error.
Yeah, Gerald, I was getting the feeling reading your
patches that you were being too glib about rewriting
code bas
On Nov 3, 2007 1:10 PM, Gerald Pfeifer <[EMAIL PROTECTED]> wrote:
> While removing the dead code I noticed that we can actually also
> strengthen the const-ness of this function.
>
> Gerald
>
> ChangeLog:
> Remove a check which never could trigger (due to the domain of the
> variable in question) a
