Re: dlls/shlwapi/assoc.c:fix ASSOC_GetExecutable not to use uninitialised variable

2008-10-20 Thread Joris Huizer
--- On Sun, 10/19/08, Rob Shearman <[EMAIL PROTECTED]> wrote: > > The information is added at commit time so it won't > make any > difference if you just run "git format-patch" > after configuring the > above settings, it matters what the settings were when you > committed. > > If you haven't com

Re: dlls/shlwapi/assoc.c:fix ASSOC_GetExecutable not to use uninitialised variable

2008-10-19 Thread Rob Shearman
2008/10/18 Joris Huizer <[EMAIL PROTECTED]>: > --- On Fri, 10/17/08, Austin English <[EMAIL PROTECTED]> wrote: >> >> git repo-config user.name "Your Name" >> git repo-config user.email "[EMAIL PROTECTED]" >> > > Uhm no that doesn't work. I had already tried that (or actually, the > equivalent of a

Re: dlls/shlwapi/assoc.c:fix ASSOC_GetExecutable not to use uninitialised variable

2008-10-19 Thread Joris Huizer
--- On Fri, 10/17/08, Austin English <[EMAIL PROTECTED]> wrote: > > git repo-config user.name "Your Name" > git repo-config user.email "[EMAIL PROTECTED]" > Uhm no that doesn't work. I had already tried that (or actually, the equivalent of adding these to .git/config) but it didn't make any dif

Re: dlls/shlwapi/assoc.c:fix ASSOC_GetExecutable not to use uninitialised variable

2008-10-17 Thread Austin English
On Fri, Oct 17, 2008 at 5:57 AM, Joris Huizer <[EMAIL PROTECTED]> wrote: > --- On Thu, 10/16/08, Austin English <[EMAIL PROTECTED]> wrote: >> >> "From: Joris Huizer >> <[EMAIL PROTECTED](none)>" >> >> Minor, but please fix your e-mail in the patch: >> >> Also, please set patch extensions to .txt, i

Re: dlls/shlwapi/assoc.c:fix ASSOC_GetExecutable not to use uninitialised variable

2008-10-17 Thread Joris Huizer
--- On Thu, 10/16/08, Austin English <[EMAIL PROTECTED]> wrote: > > "From: Joris Huizer > <[EMAIL PROTECTED](none)>" > > Minor, but please fix your e-mail in the patch: > > Also, please set patch extensions to .txt, it makes it > easier to read > in browser. > Alright, I did a resent with the

Re: dlls/shlwapi/assoc.c:fix ASSOC_GetExecutable not to use uninitialised variable

2008-10-16 Thread Austin English
On Tue, Oct 14, 2008 at 5:11 PM, Joris Huizer <[EMAIL PROTECTED]> wrote: > When pszExtra is unequal to zero, set pszExtraFromReg to zero as it'll get > free'd later on; > > (Another way would be to set the variable to NULL explicitly if it's > desirable to make this case very explicit) > > > > >