Re: dplay: directplay should initialize session Guid patch + conformance tests

2007-02-27 Thread Detlef Riekenberg
On Di, 2007-02-27 at 13:15 +0100, Alessandro Pignotti wrote: > +dlls/dplayx/tests/Makefile That is will not work since today, as the format changed. The correct entry is created by "tools/make_makefiles" I updated the wiki, that autogenerated code should not be included in a Patch -- By b

Re: dplay: directplay should initialize session Guid patch +conformance tests

2007-02-27 Thread H. Verbeet
On 27/02/07, Dmitry Timoshkov <[EMAIL PROTECTED]> wrote: > +BOOL FAR PASCAL EnumConnectionsCallback(LPCGUID lpguidSP, LPVOID lpConnection, > + DWORD dwConnectionSize, LPCDPNAME lpName, DWORD dwFlags, > + LPVOID lpContext) > +{ This doesn't look like a proper type of callb ack for IDirectPlayX_

Re: dplay: directplay should initialize session Guid patch +conformance tests

2007-02-27 Thread Dmitry Timoshkov
"Alessandro Pignotti" <[EMAIL PROTECTED]> wrote: +BOOL FAR PASCAL EnumConnectionsCallback(LPCGUID lpguidSP, LPVOID lpConnection, + DWORD dwConnectionSize, LPCDPNAME lpName, DWORD dwFlags, + LPVOID lpContext) +{ This doesn't look like a proper type of callb ack for IDirectPlayX_EnumConnectio

Re: dplay: directplay should initialize session Guid patch + conformance tests

2007-02-27 Thread Kai Blin
On Saturday 24 February 2007 22:10, Alessandro Pignotti wrote: > Thanks for the suggestions, this version of the patch uses IsEqualGUID and > eliminates C++ style comments and insert a proper copyright notice in the > added file You might want to use #include "wine/test.h" instead of #include , a

Re: dplay: directplay should initialize session Guid patch + conformance tests

2007-02-24 Thread H. Verbeet
On 24/02/07, Stefan Dösinger <[EMAIL PROTECTED]> wrote: Use todo_wine ok(memcmp(&sessionDesc.guidInstance,&zeroGuid,16),"Session guid not initialized"); Afaik the proper way is to use IsEqualGUID() rather than memcmp().

Re: dplay: directplay should initialize session Guid patch + conformance tests

2007-02-24 Thread Paul Vriens
Alessandro Pignotti wrote: On Saturday 24 February 2007 19:31, Stefan Dösinger wrote: todo_wine ok(memcmp(&sessionDesc.guidInstance,&zeroGuid,16),"Session guid not initialized"); For tests which are known to fail This version of the patch follows Stefan's advice. -

Re: dplay: directplay should initialize session Guid patch + conformance tests

2007-02-24 Thread Stefan Dösinger
Am Samstag 24 Februar 2007 17:25 schrieb Alessandro Pignotti: > Hi everyone, > the directx sdk says that directplay has to initialize sesison guid in > SESSIONDESC2 struct that is passed by the application with the Open call. > This patch adresses that issue and includes proper conformance test. >