Mike McCormack wrote:
Do you still think my third patch has the problem?
I stand corrected.
Sorry about the noise.
Shachar
--
Shachar Shemesh
Lingnu Open Source Consulting ltd.
http://www.lingnu.com/
Shachar Shemesh wrote:
However, with your patch, things are different. The "revents" equivalent
is stored in an array dedicated to the epoll results, and it is
impossible for the del-user function to clear it. We do check that
"Events" is not zero, but it's not. We therefor think that the events
Mike McCormack wrote:
Just got your last mail regarding races... From what I can see, it
should now behave the same way as select_loop().
No, it does not. Sorry.
When using poll, the important field we look at is revents. Let's recap
the problem:
1. epoll is called, and marks users at offsets 1 2
Mike Hearn addressed the need for a repository of uncommitted patches.
Sounds like the sort of thing I would have said, yes. I never set up
such a list though.
Maybe I should bug Jeremy for a Wiki again :)
Shachar Shemesh wrote:
+r = epoll_ctl( epoll_fd, EPOLL_CTL_DEL, fd, &eev );
+assert( 0 == r );
This assert still depends on the removal semantics. If it's ok for the
users to close the Unix fd before removing it from the poll array, you
may find that it's already gone and the assert wi
Mike McCormack wrote:
Shachar Shemesh wrote:
Read the comment in the appropriate section of my code. You have a
race here that will crash you occasionally.
Fixed.
Ahmm. I'm not so sure.
Did you also handle the case where 1, 2 and 3 were flagged, 1 releases
3, and 2 asks for a new fd and receives
Mike McCormack wrote:
I mean I've allocated an array of 10 struct epoll_events to receive
events from epoll, and I plan to dynamically allocate it later.
I have greater plans for wineserver :-)
As part of those plans, I'm going to ask some kernel gurus whether
that's strictly necessary. If it's n
Shachar Shemesh wrote:
* used direct syscalls as my libc doesn't have epoll_* functions
Which Alexandre already asked not to. In any case, if you do, you have
to add a copyright notice to the authors of the header file who's
content you are copying.
OK, fixed.
* fixed array of epoll_event struct
Mike McCormack wrote:
Shachar Shemesh wrote:
After a discussion with Alexandre on IRC I came to the conclusion
that nothing I will do will make this patch go in. Mike, please add
it to your list of "uncommitted patches".
Hi Shachar,
I'm not sure which Mike the above is addressed at... :)
Mike He
Shachar Shemesh wrote:
After a discussion with Alexandre on IRC I came to the conclusion that
nothing I will do will make this patch go in. Mike, please add it to
your list of "uncommitted patches".
Hi Shachar,
I'm not sure which Mike the above is addressed at... :)
I agree epoll is something wor
Hi,
On Wed, Sep 08, 2004 at 12:22:53PM +0300, Shachar Shemesh wrote:
> After a discussion with Alexandre on IRC I came to the conclusion that
> nothing I will do will make this patch go in. Mike, please add it to
> your list of "uncommitted patches".
I'm a bit sad to hear that.
After all epoll()
After a discussion with Alexandre on IRC I came to the conclusion that
nothing I will do will make this patch go in. Mike, please add it to
your list of "uncommitted patches".
There is such a list? If so then Mike, could you add my systray patch
and debug delay patch? I'm always losing the links
Alexandre Julliard wrote:
Shachar Shemesh <[EMAIL PROTECTED]> writes:
I'm sorry for being a pest about this. I was wondering whether there
is anything that needs to be done on that one in order to facilitate
committing this patch?
It needs some cleaning up, you need to find a way to make fe
Shachar Shemesh <[EMAIL PROTECTED]> writes:
> I'm sorry for being a pest about this. I was wondering whether there
> is anything that needs to be done on that one in order to facilitate
> committing this patch?
It needs some cleaning up, you need to find a way to make fewer
changes to the poll()
Hi Alexandre,
I'm sorry for being a pest about this. I was wondering whether there is
anything that needs to be done on that one in order to facilitate
committing this patch?
Shachar
--
Shachar Shemesh
Lingnu Open Source Consulting ltd.
http://www.lingnu.com/
15 matches
Mail list logo
