Re: advapi32: fix a too small buffer in CredUnmarshalCredentialW [try2]

2012-11-15 Thread Hans Leidekker
On Thu, 2012-11-15 at 09:41 +0100, Stefan Leichter wrote: > i have to say sorry, this answer is rude. > > But i don't like to do unnecessary iteration on source code especially when > the "complain" has been in the previous version too. Source code usually does > not get better from iteration to

Re: advapi32: fix a too small buffer in CredUnmarshalCredentialW [try2]

2012-11-15 Thread Stefan Leichter
Wednesday 14 November 2012 Stefan Leichter > Wednesday 14 November 2012 Hans Leidekker > > > On Wed, 2012-11-14 at 16:28 +0100, Stefan Leichter wrote: > > > @@ -2053,6 +2053,8 @@ static BOOL cred_decode( const WCHAR *cred, > > > unsigned int len, char *buf ) > > > > > > char c0, c1, c2, c3

Re: advapi32: fix a too small buffer in CredUnmarshalCredentialW [try2]

2012-11-14 Thread Stefan Leichter
Wednesday 14 November 2012 Hans Leidekker > On Wed, 2012-11-14 at 16:28 +0100, Stefan Leichter wrote: > > @@ -2053,6 +2053,8 @@ static BOOL cred_decode( const WCHAR *cred, > > unsigned int len, char *buf ) > > > > char c0, c1, c2, c3; > > const WCHAR *p = cred; > > > > +TRACE("%s\n

Re: advapi32: fix a too small buffer in CredUnmarshalCredentialW [try2]

2012-11-14 Thread Hans Leidekker
On Wed, 2012-11-14 at 16:28 +0100, Stefan Leichter wrote: > @@ -2053,6 +2053,8 @@ static BOOL cred_decode( const WCHAR *cred, unsigned > int len, char *buf ) > char c0, c1, c2, c3; > const WCHAR *p = cred; > > +TRACE("%s\n", debugstr_wn(cred,len)); This string is already traced i

Re: fix a too small buffer in CredUnmarshalCredentialW

2012-11-14 Thread Stefan Leichter
Wednesday 14 November 2012 Hans Leidekker > On Wed, 2012-11-14 at 09:48 +0100, Stefan Leichter wrote: > > +char buffer[6]; > > +unsigned int buflen, *size = (unsigned int*) buffer; > > > > -if (len < 9 || !cred_decode( cred + 3, 6, (char *)&size ) || > > !size || size % si

Re: fix a too small buffer in CredUnmarshalCredentialW

2012-11-14 Thread Hans Leidekker
On Wed, 2012-11-14 at 09:48 +0100, Stefan Leichter wrote: > +char buffer[6]; > +unsigned int buflen, *size = (unsigned int*) buffer; > > -if (len < 9 || !cred_decode( cred + 3, 6, (char *)&size ) || !size > || size % sizeof(WCHAR)) > +if (len < 9 || !cred_decode(