Re: [RFC] gameux.dll implementation stub [try 2]

2010-06-20 Thread Henri Verbeet
2010/6/19 Vincent Povirk : > I would change the second argument type of the instance creation > functions to IUnknown**. When I see an LPVOID* argument on a > COM-related function, I immediately expect to see a REFIID argument > and a QueryInterface somewhere in the function. Actually, when I see

Re: [RFC] gameux.dll implementation stub [try 2]

2010-06-18 Thread Vincent Povirk
I don't have as much to say this time. You should release the interfaces you create in your tests, so there are no memory leaks. I would change the second argument type of the instance creation functions to IUnknown**. When I see an LPVOID* argument on a COM-related function, I immediately expect

Re: gameux.dll implementation stub

2010-06-09 Thread Rico Schüller
Am 08.06.2010 12:56, schrieb Mariusz Pluciński: Hello As you maybe know, I'm working on implementation of Game Explorer in the Google Summer of Code. Main part of my work is now implementing gaming APIs stored in gameux.dll library. I already sent patches with headers, and I'm currently in the st

Re: gameux.dll implementation stub

2010-06-08 Thread Vincent Povirk
+HRESULT IGameExplorer_create(IUnknown *pUnkOuter, REFIID riid, LPVOID *ppObj) +{ +TRACE("(%p, %s, %p)\n", pUnkOuter, debugstr_guid(riid), ppObj); + +if( IsEqualIID( riid, &IID_IGameExplorer )) This won't work if the caller asks for IUnknown. In general, if you get a REFIID and void**, you

Re: gameux.dll implementation stub

2010-06-08 Thread James Mckenzie
Mariusz Pluciński wrote at Jun 8, 2010 6:56 AM > >Hello Greetings. >As you maybe know, I'm working on implementation of Game Explorer in >the Google Summer of Code. Main part of my work is now implementing >gaming APIs stored in gameux.dll library. I already sent patches >with headers, and I'm c