Re: gdiplus: add a drawing test for GdipFillRectangleI

2009-02-10 Thread Nikolay Sivov
Vincent Povirk wrote: This is a very simple drawing test that I've created to establish a precedent for drawing tests in gdiplus. Gdiplus currently has no tests that draw things and then check what was drawn. I've added some functions that should make this easy. It's important to get this

Re: gdiplus: add a drawing test for GdipFillRectangleI

2009-02-10 Thread Vincent Povirk
As for me I'm not against it if it'll work stably, but will this really help? It's much easier to check this visually, comparing with native output. I think it will help. It should be stable as long as we are careful about how strict the tests are. It's probably not as appropriate to be this

Re: gdiplus: add a drawing test for GdipFillRectangleI

2009-02-10 Thread Nikolay Sivov
Vincent Povirk wrote: As for me I'm not against it if it'll work stably, but will this really help? It's much easier to check this visually, comparing with native output. I think it will help. It should be stable as long as we are careful about how strict the tests are. It's probably not

Re: gdiplus: add a drawing test for GdipFillRectangleI

2009-02-10 Thread Vincent Povirk
P.S. there's no place for todo_wine in you expect_pixel. You can write todo_wine expect_pixel(...);