Re: kernel32: Tiny improvement to the GetVolumePathNameW stub (try 4)

2008-08-21 Thread James Hawkins
On Thu, Aug 21, 2008 at 2:46 PM, Louis. Lenders [EMAIL PROTECTED] wrote: You've handled *a* successful case, but what about the error case? As i said already in the mail with the patch, it might be *a* case, but this is the case that most apps will follow as far as i can see. Futhermore,

Re: kernel32: Tiny improvement to the GetVolumePathNameW stub (try 4)

2008-08-21 Thread Louis. Lenders
- Original Message From: James Hawkins [EMAIL PROTECTED] To: Louis. Lenders [EMAIL PROTECTED] Cc: wine-devel@winehq.org Sent: Thursday, 21 August, 2008 3:55:07 PM Subject: Re: kernel32: Tiny improvement to the GetVolumePathNameW stub (try 4) That whole paragraphs reads hack now

Re: kernel32: Tiny improvement to the GetVolumePathNameW stub (try 4)

2008-08-21 Thread James Hawkins
to the GetVolumePathNameW stub (try 4) That whole paragraphs reads hack now, fix later, which is definitely not acceptable. Well, I would call it a semi-stub, there's more of them scattered all over the wine-source. But if opinions are it's too hackish, that's fine with me, I was only trying

Re: kernel32: Tiny improvement to the GetVolumePathNameW stub (try 4)

2008-08-21 Thread Michael Karcher
Am Donnerstag, den 21.08.2008, 13:26 -0500 schrieb James Hawkins: Also, you're copying 4 bytes of filename into volumepathname. I don't think you understand what lstrcpyn does. Imagine this case: volumepathname = buflen = 8 filename = C:\\file After the call to lstrcpyn:

Re: kernel32: Tiny improvement to the GetVolumePathNameW stub (try 4)

2008-08-21 Thread John Klehm
On Thu, Aug 21, 2008 at 4:35 PM, Michael Karcher [EMAIL PROTECTED] wrote: page, stating that lstrcpyn(dest,abcdefghi,4) puts abc into dest. Seems like Wine's version at least always null terminates it, so abc\0. Just so anyone, who like me had to look it up, can see.

Re: kernel32: Tiny improvement to the GetVolumePathNameW stub (try 4)

2008-08-21 Thread Michael Karcher
Am Donnerstag, den 21.08.2008, 17:35 -0500 schrieb John Klehm: On Thu, Aug 21, 2008 at 4:35 PM, Michael Karcher [EMAIL PROTECTED] wrote: page, stating that lstrcpyn(dest,abcdefghi,4) puts abc into dest. Seems like Wine's version at least always null terminates it, so abc\0. Sorry if my