Re: kernel32: fix PROFILE_Load to handle mac line endings (try 3)

2008-09-23 Thread Erik Inge Bolsø
On Sun, 21 Sep 2008, Michael Karcher wrote: Am Sonntag, den 21.09.2008, 02:15 +0200 schrieb Erik Inge Bolsø: +ok(1, %s\n, content); Please use trace(...) instead of ok(1,...). Also, outputting a string with newline characters might be irritating, especially as one might need a hex viewer

Re: kernel32: fix PROFILE_Load to handle mac line endings (try 3)

2008-09-23 Thread Erik Inge Bolsø
On Sun, 21 Sep 2008, Michael Karcher wrote: Am Sonntag, den 21.09.2008, 15:13 +0200 schrieb Erik Inge Bolsø: Without modifying the test messages, we'll only get a line number, and no mention of which data caused the test to fail. You just look some lines upwards to the trace output. It's

Re: kernel32: fix PROFILE_Load to handle mac line endings (try 3)

2008-09-21 Thread Michael Karcher
Am Sonntag, den 21.09.2008, 02:15 +0200 schrieb Erik Inge Bolsø: +ok(1, %s\n, content); Please use trace(...) instead of ok(1,...). Also, outputting a string with newline characters might be irritating, especially as one might need a hex viewer to see the difference between the CR-only and

Re: kernel32: fix PROFILE_Load to handle mac line endings (try 3)

2008-09-21 Thread Michael Karcher
Am Sonntag, den 21.09.2008, 15:13 +0200 schrieb Erik Inge Bolsø: -ok(ret == 18, Expected 18, got %d\n, ret); +ok(ret == 18, Run %d: Expected 18, got %d\n, run, ret); Questions to everyone: I suppose if the trace above indicates the run number, these modifications are unneded. Do