Re: listbox: ownerdraw fix

2003-11-17 Thread Dimitrie O. Paun
On November 17, 2003 10:47 am, Huw D M Davies wrote: > I guess that's because there are several other calls to > LISTBOX_GetItemRect that have the same syntax. Note that > LISTBOX_GetItemRect can return -1 on error. Of course, my bad, I've commented without actually checking out the code. Please

Re: listbox: ownerdraw fix

2003-11-17 Thread Huw D M Davies
On Mon, Nov 17, 2003 at 10:33:33AM -0500, Dimitrie O. Paun wrote: > On November 17, 2003 10:16 am, Huw D M Davies wrote: > > +if (LISTBOX_GetItemRect( descr, index, &rect ) == 1) > > OK, I very sorry to nick pick so much, but this test is not > only strange in C, but it's a bit dangerous as we

Re: listbox: ownerdraw fix

2003-11-17 Thread Dimitrie O. Paun
On November 17, 2003 10:16 am, Huw D M Davies wrote: > +if (LISTBOX_GetItemRect( descr, index, &rect ) == 1) OK, I very sorry to nick pick so much, but this test is not only strange in C, but it's a bit dangerous as well, since in the future LISTBOX_GetItemRect may return something >1 for TRUE

Re: listbox: ownerdraw fix

2003-11-17 Thread Huw D M Davies
On Mon, Nov 17, 2003 at 09:59:20AM -0500, Dimitrie O. Paun wrote: > Why not simply invalidate rect always, even when not in owner draw? Works for me. Aric Stewart <[EMAIL PROTECTED]> invalidate items on setselection. -- Huw Davies [EMAIL PROTECTED] Index: controls/listbox.c =

Re: listbox: ownerdraw fix

2003-11-17 Thread Dimitrie O. Paun
On November 17, 2003 07:33 am, Huw D M Davies wrote: > -LISTBOX_RepaintItem( hwnd, descr, i, ODA_SELECT ); > +if (!IS_OWNERDRAW(descr)) > +LISTBOX_RepaintItem( hwnd, descr, i, ODA_SELECT ); > +else > +LISTBOX_InvalidateItemRect(hwn