Re: mshtml/tests: Fix return value of ActiveScript_SetScriptState.

2010-05-08 Thread Jacek Caban
On 5/7/10 11:47 PM, Gerald Pfeifer wrote: On Mon, 3 May 2010, Jacek Caban wrote: On 5/2/10 9:16 PM, Gerald Pfeifer wrote: IActiveScriptSite_OnStateChange is described to return S_OK upon success, so instead of ignoring its return value and unconditionally returning S_OK it strikes me

Re: mshtml/tests: Fix return value of ActiveScript_SetScriptState.

2010-05-08 Thread Gerald Pfeifer
On Mon, 3 May 2010, Jacek Caban wrote: On 5/2/10 9:16 PM, Gerald Pfeifer wrote: IActiveScriptSite_OnStateChange is described to return S_OK upon success, so instead of ignoring its return value and unconditionally returning S_OK it strikes me that we should return its result instead. In this

Re: mshtml/tests: Fix return value of ActiveScript_SetScriptState.

2010-05-03 Thread Jacek Caban
Hi Gerald, On 5/2/10 9:16 PM, Gerald Pfeifer wrote: IActiveScriptSite_OnStateChange is described to return S_OK upon success, so instead of ignoring its return value and unconditionally returning S_OK it strikes me that we should return its result instead. In this case returning S_OK is