Re: msi: begin support for finding network last sources in find_published_source

2009-02-20 Thread Aric Stewart
Hello, No i never saw the e-mail that you send to Jeremy. I will admit that i did not dig really deep for this patch as it appeared to me that the fix was obvious (there was even a fixme in the code saying we needed to do what the installer was asking for) There are about 4 CAB files

Re: msi: begin support for finding network last sources in find_published_source

2009-02-20 Thread James Hawkins
On Fri, Feb 20, 2009 at 4:45 AM, Aric Stewart a...@codeweavers.com wrote: Hello, No i never saw the e-mail that you send to Jeremy. I will admit that i did not dig really deep for this patch as it appeared to me that the fix was obvious (there was even a fixme in the code saying we needed

Re: msi: begin support for finding network last sources in find_published_source

2009-02-20 Thread Aric Stewart
Ok i am following you but. James Hawkins wrote: On Fri, Feb 20, 2009 at 4:45 AM, Aric Stewart a...@codeweavers.com wrote: Hello, . . . No, I think the patch is wrong in that if you remove the original media and the stored cabs, the install will fail. By that thinking then the whole function

Re: msi: begin support for finding network last sources in find_published_source

2009-02-20 Thread James Hawkins
On Fri, Feb 20, 2009 at 9:56 AM, Aric Stewart a...@codeweavers.com wrote: Ok i am following you but. James Hawkins wrote: On Fri, Feb 20, 2009 at 4:45 AM, Aric Stewart a...@codeweavers.com wrote: Hello, . . . No, I think the patch is wrong in that if you remove the original media

Re: msi: begin support for finding network last sources in find_published_source

2009-02-19 Thread James Hawkins
On Thu, Feb 19, 2009 at 12:28 PM, Aric Stewart a...@codeweavers.com wrote: Fix for office 2007 sp 1 install. --- dlls/msi/media.c | 33 + 1 files changed, 33 insertions(+), 0 deletions(-) I believe you're going down the wrong road with respect to the