Re: msvcrt: Fix EOF behavior on read from pipe

2008-02-09 Thread Damjan Jovanovic
On Feb 8, 2008 8:03 PM, Dan Kegel [EMAIL PROTECTED] wrote: Damjan wrote The problem is more general: consoles *also* break on short reads (Java 1.4.1's gdb takes 1 command then quits because it thinks it's the end of file) Try my patch, it should help that case. It only helps if I change

Re: msvcrt: Fix EOF behavior on read from pipe

2008-02-09 Thread Dan Kegel
On Feb 9, 2008 2:15 AM, Damjan Jovanovic [EMAIL PROTECTED] wrote: Try my patch, it should help that case. It only helps if I change +if (type != FILE_TYPE_PIPE) { to +if (type != FILE_TYPE_PIPE type != FILE_TYPE_CHAR) { That makes me as uneasy as I bet it does you;

Re: msvcrt: Fix EOF behavior on read from pipe

2008-02-09 Thread Damjan Jovanovic
On Feb 9, 2008 5:27 PM, Dan Kegel [EMAIL PROTECTED] wrote: On Feb 9, 2008 2:15 AM, Damjan Jovanovic [EMAIL PROTECTED] wrote: Try my patch, it should help that case. It only helps if I change +if (type != FILE_TYPE_PIPE) { to +if (type != FILE_TYPE_PIPE type

re: msvcrt: Fix EOF behavior on read from pipe

2008-02-08 Thread Dan Kegel
Damjan wrote The problem is more general: consoles *also* break on short reads (Java 1.4.1's gdb takes 1 command then quits because it thinks it's the end of file) Try my patch, it should help that case. I'm sure short read != end of file for ordinary files either, especially in *nix where

Re: msvcrt: Fix EOF behavior on read from pipe

2008-02-08 Thread Damjan Jovanovic
On Feb 8, 2008 4:31 PM, Dan Kegel [EMAIL PROTECTED] wrote: Nguyễn Thái Ngọc Duy's patch was almost right, he forgot a test case, and he neglected to move where EOF is detected for pipes instead of just removing it. Should fix http://bugs.winehq.org/show_bug.cgi?id=11187 The problem is