Re: msxml3: avoid a dangling else (LLVM/Clang)

2012-05-14 Thread Michael Stefaniuc
Hello Austin, On 05/14/2012 08:01 AM, Austin English wrote: diff --git a/dlls/msxml3/domdoc.c b/dlls/msxml3/domdoc.c index 6805c75..14fd01b 100644 --- a/dlls/msxml3/domdoc.c +++ b/dlls/msxml3/domdoc.c @@ -2277,8 +2277,10 @@ static HRESULT WINAPI domdoc_loadXML( /* skip

Re: msxml3: avoid a dangling else (LLVM/Clang)

2012-05-14 Thread Eric Pouech
while (*ptr) if (isspaceW(*ptr)) ptr++; else break; I do not mind terse code but that kinda overdoes it. I would put the else on a separate line. trafic on wine-devel is rather low those days what about opening a code-style flame-war ? A+ -- Eric

Re: msxml3: avoid a dangling else (LLVM/Clang)

2012-05-14 Thread Michael Stefaniuc
On 05/14/2012 11:47 AM, Eric Pouech wrote: while (*ptr) if (isspaceW(*ptr)) ptr++; else break; I do not mind terse code but that kinda overdoes it. I would put the else on a separate line. trafic on wine-devel is rather low those days what about