Re: msxml3: tests/xmlelem.c: VT_EMPTY is not a string

2008-06-09 Thread Michael Stefaniuc
Dan Kegel wrote: Casting a VT_EMPTY to a string gets you a null string. The test was doing that and taking the string length, then comparing to zero. Better to simply compare to null; that's a stronger test, and avoids generating a behind-the-scenes exception. Passes on Wine and XP, and

Re: msxml3: tests/xmlelem.c: VT_EMPTY is not a string

2008-06-09 Thread Dan Kegel
On Mon, Jun 9, 2008 at 2:32 AM, Michael Stefaniuc [EMAIL PROTECTED] wrote: -ok(lstrlenW(V_BSTR(vValue)) == 0, Expected empty value\n); +ok(V_BSTR(vValue) == (void *)0, Expected null value\n); Is there a problem with using NULL instead of (void *)0? NULL would probably be fine. (I