Re: ntdll: Fixed some heap allocation stalls

2012-11-07 Thread Alexandre Julliard
Steaphan Greene writes: > On 11/03/2012 10:28 AM, Matteo Bruni wrote: >> Speaking of which, it might be a nice followup patch to add some free >> lists usage stats, to get some idea of what different applications do >> in that regard. > > Well, my code instrumentation consisted of fprintf()s, whi

Re: ntdll: Fixed some heap allocation stalls

2012-11-03 Thread Steaphan Greene
On 11/03/2012 10:28 AM, Matteo Bruni wrote: 2012/11/3 Steaphan Greene: On 11/03/2012 09:04 AM, Matteo Bruni wrote: 2012/11/2 Steaphan Greene: Running a game in wine showed it performing terribly. I traced this to the fact that it allocates and deallocates tiny memory chunks over and over (I s

Re: ntdll: Fixed some heap allocation stalls

2012-11-03 Thread Steaphan Greene
On 11/03/2012 02:09 AM, Matej Špindler wrote: On 03. 11. 2012 01:20, Dan Kegel wrote: Which game were you testing? League of Legends has similar issues with memory allocation. This patch does something similar: http://uz.sns.it/~ranma42/iLoL/spectator-fix-v2/0001-ntdll-Improve-performace-of

Re: ntdll: Fixed some heap allocation stalls

2012-11-03 Thread Matteo Bruni
2012/11/3 Steaphan Greene : > On 11/03/2012 09:04 AM, Matteo Bruni wrote: >> >> 2012/11/2 Steaphan Greene: >>> >>> Running a game in wine showed it performing terribly. I traced this to >>> the >>> fact that it allocates and deallocates tiny memory chunks over and over >>> (I >>> suspect it's in C

Re: ntdll: Fixed some heap allocation stalls

2012-11-03 Thread Steaphan Greene
On 11/03/2012 09:04 AM, Matteo Bruni wrote: 2012/11/2 Steaphan Greene: Running a game in wine showed it performing terribly. I traced this to the fact that it allocates and deallocates tiny memory chunks over and over (I suspect it's in C++ and passing things by value everywhere). This led to

Re: ntdll: Fixed some heap allocation stalls

2012-11-03 Thread Matteo Bruni
2012/11/2 Steaphan Greene : > Running a game in wine showed it performing terribly. I traced this to the > fact that it allocates and deallocates tiny memory chunks over and over (I > suspect it's in C++ and passing things by value everywhere). This led to > huge stalls because the heap bins were

Re: ntdll: Fixed some heap allocation stalls

2012-11-03 Thread Matej Špindler
On 03. 11. 2012 01:20, Dan Kegel wrote: Which game were you testing? League of Legends has similar issues with memory allocation. This patch does something similar: http://uz.sns.it/~ranma42/iLoL/spectator-fix-v2/0001-ntdll-Improve-performace-of-heap-allocation-v2.patch I have it in my tree

RE: ntdll: Fixed some heap allocation stalls

2012-11-02 Thread Daniel Lehman
>> Which game were you testing? i dunno about the game, but i saw similar stalls in our software a huge batch process that consumed about 1 GB on Windows would both run slower and eat up about 2 GB on Wine before crashing i made a similar change to Steaphan's that not only improved performance,

re: ntdll: Fixed some heap allocation stalls

2012-11-02 Thread Dan Kegel
Which game were you testing?