Re: ntdll: remove an unnecessary NULL check : Coverity

Dmitry Timoshkov wrote: NtCreateMailslotFile is a public API, so probably it should handle the case when attr is NULL. I see the same problem at least in NtCreateNamedPipeFile. In general, handling of OBJECT_ATTRIBUTES in ntdll is not consistent, but fixing it properly most likely a test is n

Re: ntdll: remove an unnecessary NULL check : Coverity

"Jeff L" <[EMAIL PROTECTED]> wrote: Looking a bit further it seems that NtCreateMailslotFile is only called from CreateMailslotW. If there is a problem with a NULL then it stems from there. NtCreateMailslotFile is a public API, so probably i

Re: ntdll: remove an unnecessary NULL check : Coverity

Jeff L wrote: Dmitry Timoshkov wrote: Yes, 'attr' is used without a NULL check earlier, but that's an actual bug, and that's where the code needs to be fixed. So in this case my change is ok for the tidy up that it is, it just that there is another problem. Is this in bugzilla? Jeff Lookin

Re: ntdll: remove an unnecessary NULL check : Coverity

Dmitry Timoshkov wrote: "Jeff Latimer" <[EMAIL PROTECTED]> wrote: Coverity Cid:344 highlighted a REVERSE-INULL. This patch removes the redundant null tests as it is clear from the code above that the pointer has already been used to dereference and can't be null. Yes, 'attr' is used without

Re: ntdll: remove an unnecessary NULL check : Coverity

"Jeff Latimer" <[EMAIL PROTECTED]> wrote: Coverity Cid:344 highlighted a REVERSE-INULL. This patch removes the redundant null tests as it is clear from the code above that the pointer has already been used to dereference and can't be null. Yes, 'attr' is used without a NULL check earlier, bu