Make winecfg a control panel applet? [was: programs/winefontcfg: Add winefontcfg]

2007-07-22 Thread Frank Richter
On 12.07.2007 18:29, Stefan Dösinger wrote: I am not sure if it is a good idea to wrap the winecfg functionality into something complex like a control panel applet(which is tied to shell folders in some way). A user can easilly break core parts of wine with winecfg. The more complex the

Re: programs/winefontcfg: Add winefontcfg (try 3)

2007-07-13 Thread Dan Kegel
All in all the app looks like it's coming along nicely. I apologize for catching so few problems in each pass, but we'll get there. Is there a way you can get the path to the currently running instance instead of hardcoding it? Then it would work even if winefontcfg isn't on the PATH. +

Re: programs/winefontcfg: Add winefontcfg (try 3)

2007-07-13 Thread Dan Kegel
Nigel wrote: Is there a way you can get the path to the currently running instance instead of hardcoding it? Then it would work even if winefontcfg isn't on the PATH. +GetFullPathNameW(exename, MAXSTRLEN, szFullPathName, NULL); That just prepends the current directory onto the given

Re: programs/winefontcfg: Add winefontcfg

2007-07-12 Thread Dan Kegel
On 7/11/07, Nigel Liang (梁乃強) [EMAIL PROTECTED] wrote: Sent in try 2: http://www.winehq.org/pipermail/wine-patches/2007-July/041356.html Not all the locals in FontLinkListBoxWndProc really need to be static. (e.g. 'dst') Those that really need to be static should probably be initialized to

Re: programs/winefontcfg: Add winefontcfg

2007-07-12 Thread Vijay Kiran Kamuju
Hi, Is it possible to have a separate tab for fonts in winecfg, rather than a separate program. Its my opinion of winefontcfg, rather than having a collection of configuration tools. Better have one. Thanks, VJ On 7/12/07, Dan Kegel [EMAIL PROTECTED] wrote: On 7/11/07, Nigel Liang (梁乃強)

Re: programs/winefontcfg: Add winefontcfg

2007-07-12 Thread Nigel Liang
On 7/12/07, Vijay Kiran Kamuju [EMAIL PROTECTED] wrote: Hi, Is it possible to have a separate tab for fonts in winecfg, rather than a separate program. Its my opinion of winefontcfg, rather than having a collection of configuration tools. Better have one. Thanks, VJ The main reason I wrote a

Re: programs/winefontcfg: Add winefontcfg

2007-07-12 Thread Dan Kegel
VJ wrote: Is it possible to have a separate tab for fonts in winecfg, rather than a separate program. Its my opinion of winefontcfg, rather than having a collection of configuration tools. Better have one. That's the wrong direction, I think, and here's why: Native uses separate tools for

Re: programs/winefontcfg: Add winefontcfg

2007-07-12 Thread Stefan Dösinger
Am Donnerstag, 12. Juli 2007 16:54 schrieb Dan Kegel: VJ wrote: Is it possible to have a separate tab for fonts in winecfg, rather than a separate program. Its my opinion of winefontcfg, rather than having a collection of configuration tools. Better have one. That's the wrong direction,

Re: programs/winefontcfg: Add winefontcfg

2007-07-12 Thread Nigel Liang (梁乃強)
On 7/11/07, Dmitry Timoshkov [EMAIL PROTECTED] wrote: Dan Kegel [EMAIL PROTECTED] wrote: I think those static function prototypes in winefontcfg.h should not be there. .h files are for things shared between files; your prototypes were probably put there to avoid compiler errors. Better to

Re: programs/winefontcfg: Add winefontcfg

2007-07-11 Thread Dmitry Timoshkov
Dan Kegel [EMAIL PROTECTED] wrote: I think those static function prototypes in winefontcfg.h should not be there. .h files are for things shared between files; your prototypes were probably put there to avoid compiler errors. Better to put them in the .c file if they're not used by multiple