On Sun, Jan 18, 2009 at 1:52 AM, Hin-Tak Leung hintak_le...@yahoo.co.uk wrote:
--- On Sat, 17/1/09, Luke Kenneth Casson Leighton l...@lkcl.net wrote:
but the behaviour of msvcrt wrt crlf is _definitely_
not right, as it
stands, and as a result it completely screws any
possibility for
On Sun, Jan 18, 2009 at 9:44 PM, Luke Kenneth Casson Leighton
l...@lkcl.net wrote:
On Sun, Jan 18, 2009 at 1:52 AM, Hin-Tak Leung hintak_le...@yahoo.co.uk
wrote:
I am about to go back to fix a bug with ghostscript's ijs interface when
compiled with non-MSVC: IJS is a binary protocol (for
On Sun, Jan 18, 2009 at 4:52 PM, Hin-Tak Leung hintak_le...@yahoo.co.uk wrote:
--- On Sun, 18/1/09, Luke Kenneth Casson Leighton l...@lkcl.net wrote:
the regression test test_file.py has succeeded for years
under
proprietary native win32 platforms using the proprietary
msvc compiler
to
--- On Sat, 17/1/09, Luke Kenneth Casson Leighton l...@lkcl.net wrote:
but the behaviour of msvcrt wrt crlf is _definitely_
not right, as it
stands, and as a result it completely screws any
possibility for
running python.exe under wine. completely. you
can't have files that
you write
--- On Sun, 18/1/09, Luke Kenneth Casson Leighton l...@lkcl.net wrote:
the regression test test_file.py has succeeded for years
under
proprietary native win32 platforms using the proprietary
msvc compiler
to build python.exe and python2N.dll for win32 platforms.
this particular test is
folks, hi,
i've started running the python regression tests under wine (using the
build of python i've only just created) and have started filling in
bugreports for the tests that fail, but some things occurred to me:
1) why am i the only person filling out the bugreports? :)
2) surely these
but the behaviour of msvcrt wrt crlf is _definitely_ not right, as it
stands, and as a result it completely screws any possibility for
running python.exe under wine. completely. you can't have files that
you write to, that are different from when they are read back.
ok this turns out
Luke wrote:
1) why am i the only person filling out the bugreports? :)
You got lucky and found a good test suite! If you put up
a nice easy recipe, you'll probably get some help.
2) surely these regression tests would work equally as well under the
python2.5.2.exe that you can get as part of
got it.
in stdio.h:
#if !defined _MT (which it isn't...)
__CRT_INLINE int __cdecl __MINGW_NOTHROW getc (FILE* __F)
{
return (--__F-_cnt = 0)
? (int) (unsigned char) *__F-_ptr++
: _filbuf (__F);
}
#else /* Use library functions. */
_CRTIMP int __cdecl __MINGW_NOTHROW getc (FILE*);
Luke wrote:
[MSVCRT__filbuf() needs to strip CR's.]
Here's a quickie patch that kind of gets there,
but fails an ftell test. My in-laws arrive in ten
minutes, so I probably can't go any further on
it this weekend.
There are probably other simplifications that
could be made beyond this, I
give it a bit more time - there's another one (involving fgets
followed by fread) which i'm investigating, i'll have that one nailed
as a test case in a bit, am just about to add a test case to #16790
On Sat, Jan 17, 2009 at 7:15 PM, Dan Kegel d...@kegel.com wrote:
Luke wrote:
[MSVCRT__filbuf()
spiffo, dan, jolly good show :)
that fixed both #16982 _and_ #16970 - the character reading bit - with
the exception that the ftell() position, which was wrong _before_ this
patch, is still also wrong, as you suspected.
l.
On Sat, Jan 17, 2009 at 7:15 PM, Dan Kegel d...@kegel.com wrote:
Luke
l...@gonzalez:~/src/python2.5-2.5.2$ ./python.exe Lib/test/test_file.py -v
testIteration (__main__.OtherFileTests) ... ok
--
Ran 1 test in 0.008s
OK
yaay!
so, obviously, the regression tests in python aren't _that_ good, as
Luke Kenneth Casson Leighton wrote:
l.
On Sat, Jan 17, 2009 at 7:15 PM, Dan Kegel d...@kegel.com wrote:
Luke wrote:
[MSVCRT__filbuf() needs to strip CR's.]
Here's a quickie patch that kind of gets there,
but fails an ftell test. My in-laws arrive in ten
minutes, so I
Sadly, I'm having trouble seeing how to do it this
way and get ftell() right. ftell returns the position
of the fd minus the number of bytes in the buffer.
For that to work with this scheme, I'd have to store
the number of CRs removed... and I'm not sure where
in struct iobuf that could go, or
15 matches
Mail list logo
