Re: [Patch] 0001-Support-for-winscard.dll.patch

2008-08-30 Thread frechdachs69
Hi Mounir, this morning I have found spare time to do a quick check of the winscard.dll.so you provided. So on my 64Bit AMD64 system your .so works fine so far. Maybe we can address the structure alignment problem during the next weeks/months? Let us see ... One thing: while /usr/sbin/testpcs

Re: [Patch] 0001-Support-for-winscard.dll.patch

2008-08-25 Thread frechdachs69
Thanks ... I am going to have a deep look into your sources. Regards Heiko Am Montag, 25. August 2008 10:56:25 schrieb Mounir IDRASSI: > Hi All, > > I have just been informed by one of my contacts that this discussion about > Winscard has started. > As the original author of Winscard for Wine, I'

Re: [Patch] 0001-Support-for-winscard.dll.patch

2008-08-25 Thread Mounir IDRASSI
Hi All, I have just been informed by one of my contacts that this discussion about Winscard has started. As the original author of Winscard for Wine, I'd like to inform you that I have already posted a fully functional Winscard patch for Wine on April 2007. Here is the link to it : http://www.win

Re: [Patch] 0001-Support-for-winscard.dll.patch

2008-08-23 Thread frechdachs69
Am Samstag, 23. August 2008 18:06:20 schrieb Dan Kegel: [snip] > > Okay. Shall I offer a new patch? How to do this then? Is this the only > > problem with the patch (syntactically)? To mention ... I am a git rookie > > ... > > The subject line should have said something like > winscard: implement

Re: [Patch] 0001-Support-for-winscard.dll.patch

2008-08-23 Thread Dan Kegel
On Sat, Aug 23, 2008 at 8:45 AM, frechdachs69 <[EMAIL PROTECTED]> > I am trying to prepare the winscard.dll stuff for an application written by > me. Probably I can extract some smartcard-using code (after my application > works) as a conformance test. It's a common misconception that tests should

Re: [Patch] 0001-Support-for-winscard.dll.patch

2008-08-23 Thread frechdachs69
Am Samstag, 23. August 2008 16:50:46 schrieb Dan Kegel: > Heiko wrote: > > This is my first patch using git and also for wine. > > > > Please check it and let me know which things can be made better. > > Hi! Welcome to Wine! > > You probably need to include a better description, > and some conform

Re: [Patch] 0001-Support-for-winscard.dll.patch

2008-08-23 Thread Dan Kegel
On Sat, Aug 23, 2008 at 7:50 AM, Dan Kegel <[EMAIL PROTECTED]> wrote: > You can avoid the particular problem by not including a diff for 'configure' > in the patch; the diff for configure.ac suffices. > > We have lots of pages (way too many) of advice for how to send > patches at winehq.org, but th

re: [Patch] 0001-Support-for-winscard.dll.patch

2008-08-23 Thread Dan Kegel
Heiko wrote: > This is my first patch using git and also for wine. > > Please check it and let me know which things can be made better. Hi! Welcome to Wine! You probably need to include a better description, and some conformance tests would help, too. (They should do basic error checking at leas