re: Resend: Add d3drmdef.h header file - try 3

2007-03-20 Thread Dan Kegel
Vijay wrote: Resend. Please let me why this one has been dropped. I'd guess it's because there's no code in the tree that needs it yet, and no tests for it? - Dan

Re: Resend: Add d3drmdef.h header file - try 3

2007-03-20 Thread Vijay Kiran Kamuju
Hi, We have made the tests and implementation. We are waiting for this to get into the tree. Just ironing out minor issues with our implementation. Once this gets in it would be easy to send in the implementation and tests. Thanks, VJ PS: - If implementation and tests are needed, will be

Re: Resend: Add d3drmdef.h header file - try 3

2007-03-20 Thread Dmitry Timoshkov
Vijay Kiran Kamuju [EMAIL PROTECTED] wrote: We have made the tests and implementation. We are waiting for this to get into the tree. Just ironing out minor issues with our implementation. Once this gets in it would be easy to send in the implementation and tests. How this could get in if you

Re: Resend: Add d3drmdef.h header file - try 3

2007-03-20 Thread Vijay Kiran Kamuju
Hi, Can somebody more experienced than me, please look into this? Modify and Submit to the wine-patches, please anyone who is working on wined3d. I and David Adam put a lotta effort making implementation and tests for d3drm. So that we can make older games that use vector manipulations work,

Re: Resend: Add d3drmdef.h header file - try 3

2007-03-20 Thread Dmitry Timoshkov
Vijay Kiran Kamuju [EMAIL PROTECTED] wrote: I have a very tough luck getting in my patches. eg: my wininet patches (1yr back, more testcases), comctl monthcal patch(no testcase) and now this d3drm. Please someone help David Adam and Me in this, most of the hardwork is done by David. I dont

Re: Resend: Add d3drmdef.h header file - try 3

2007-03-20 Thread Carl-Daniel Hailfinger
On 20.03.2007 09:37, Dmitry Timoshkov wrote: Vijay Kiran Kamuju [EMAIL PROTECTED] wrote: I know its very tough to get patches done by newbies to get in, esp wine. It's absolutely not hard to get patches accepted, be it Wine or any other project. But it's absolutely required to listen for

Re: Resend: Add d3drmdef.h header file - try 3

2007-03-20 Thread Dmitry Timoshkov
Carl-Daniel Hailfinger [EMAIL PROTECTED] wrote: On 20.03.2007 09:37, Dmitry Timoshkov wrote: Vijay Kiran Kamuju [EMAIL PROTECTED] wrote: I know its very tough to get patches done by newbies to get in, esp wine. It's absolutely not hard to get patches accepted, be it Wine or any other

Re: Resend: Add d3drmdef.h header file - try 3

2007-03-20 Thread Dan Kegel
Vijay wrote: We have made the tests and implementation. We are waiting for this to get into the tree. Just ironing out minor issues with our implementation. Once this gets in it would be easy to send in the implementation and tests. You need to submit them all together, I think. - Dan

Re: Resend: Add d3drmdef.h header file - try 3

2007-03-20 Thread H. Verbeet
On 20/03/07, Dan Kegel [EMAIL PROTECTED] wrote: Vijay wrote: We have made the tests and implementation. We are waiting for this to get into the tree. Just ironing out minor issues with our implementation. Once this gets in it would be easy to send in the implementation and tests. You need

Re: Resend: Add d3drmdef.h header file - try 3

2007-03-20 Thread Francois Gouget
On Mon, 19 Mar 2007, Vijay Kiran Kamuju wrote: [...] Add minimalistic d3drmdef.h [...] Something I just noticed: +#include d3dtypes.h This should be: #include d3dtypes.h If I remember correctly it's important in the public headers for compiling Winelib in some circumstances. (I'm not saying