Vitaliy Margolen wrote:
upset. Users will have their functioning installers and you will have your error
reports.
I will have my error reports? How exactly will I get them? Does average
user (or Wine) send us err: error reports? If he/she usually had, this
would be a non-issue, and asserts c
Vitaliy Margolen wrote:
I don't see how that can be if users report crashes immediately when installer
tries to show licence. Or when user tries to scroll text to the bottom so "Next"
button will become enabled.
It doesn't happen on my machine on installers I've tried (including the
infamous
Monday, August 7, 2006, 10:33:02 AM, Krzysztof Foltman wrote:
> Vitaliy Margolen wrote:
>> I think this patch takes number of asserts per line to the highest level I've
>> ever seen. Could you explain why you adding asserts everywhere (only 11 in
>> this
>> patch alone!!!)? Instead of using prope
Monday, August 7, 2006, 1:48:49 PM, Phil Krylov wrote:
>> Have you even tried your code on purposely broken rtf? How does it handle it?
> Broken rtf can only possibly break the RTF reader code, although it
> has not been happening for quite a long time. And the asserts are
> there to report Wine r
Have you even tried your code on purposely broken rtf? How does it handle it?
Broken rtf can only possibly break the RTF reader code, although it
has not been happening for quite a long time. And the asserts are
there to report Wine riched20 developer's errors, not the app
developers'.
-- Ph.
On 8/7/06, Krzysztof Foltman <[EMAIL PROTECTED]> wrote:
+#define static
That deserves a comment, at the very least! I don't think such
a define should be allowed. Can you recode without this?
I like the number of asserts. It's hard to get this stuff right,
and the asserts will help make sur
Vitaliy Margolen wrote:
I think this patch takes number of asserts per line to the highest level I've
ever seen. Could you explain why you adding asserts everywhere (only 11 in this
patch alone!!!)? Instead of using proper error handling?
Well, that's the good question. The thing is, those con
Monday, August 7, 2006, 9:27:16 AM, Krzysztof Foltman wrote:
> ChangeLog:
> * New, clean, simple selection repaint logic - should fix all
> outstanding refresh issues (and bug#5882)
> Krzysztof
I think this patch takes number of asserts per line to the highest level I've
ever seen. Could you
