Re: rsaenh(2/6): Add support for SHA-256, SHA-384, and SHA-512 (try 2)

2010-03-15 Thread Juan Lang
> ULL constants are not portable and should be avoided. Ah, right. Sorry, I only glanced at the source after checking the license. I'll fix and resend (and have a closer look.) --Juan

Re: rsaenh(2/6): Add support for SHA-256, SHA-384, and SHA-512 (try 2)

2010-03-15 Thread Alexandre Julliard
Juan Lang writes: > +/* Hash constant words K for SHA-384 and SHA-512: */ > +const static sha2_word64 K512[80] = { > + 0x428a2f98d728ae22ULL, 0x7137449123ef65cdULL, > + 0xb5c0fbcfec4d3b2fULL, 0xe9b5dba58189dbbcULL, ULL constants are not portable and should be avoided. -- Alexandre Jull

Re: rsaenh(2/6): Add support for SHA-256, SHA-384, and SHA-512

2010-03-08 Thread Juan Lang
> Is the patch missing some files? Damn, yes. I thought "git am" would be clever enough to handle that, but apparently not. Thanks. --Juan

Re: rsaenh(2/6): Add support for SHA-256, SHA-384, and SHA-512

2010-03-08 Thread Henri Verbeet
On 8 March 2010 22:36, Juan Lang wrote: > Uses implementation from Aaron Gifford, > http://www.aarongifford.com/computers/sha.html  (It's BSD licensed.) > Is the patch missing some files?