Re: services.exe: Reduce Registry access to KEY_READ or MAXIMUM_ALLOWED wherever possible (try 2)

2009-11-30 Thread Alexandre Julliard
Paul Chitescu writes: > Oh, I see it now. > > This means that currently the old strings are leaked if the new strings > provided are NULL. No, they remain unchanged in that case. -- Alexandre Julliard julli...@winehq.org

Re: services.exe: Reduce Registry access to KEY_READ or MAXIMUM_ALLOWED wherever possible (try 2)

2009-11-30 Thread Paul Chitescu
On Monday 30 November 2009 05:51:35 pm Alexandre Julliard wrote: > Paul Chitescu writes: > > > @@ -569,11 +569,11 @@ DWORD svcctl_ChangeServiceConfigW( > > new_entry.config.lpDisplayName = strdupW(lpDisplayName); > > } > > > > -*service->service_entry = new_entry; > > -sav

Re: services.exe: Reduce Registry access to KEY_READ or MAXIMUM_ALLOWED wherever possible (try 2)

2009-11-30 Thread Alexandre Julliard
Paul Chitescu writes: > @@ -569,11 +569,11 @@ DWORD svcctl_ChangeServiceConfigW( > new_entry.config.lpDisplayName = strdupW(lpDisplayName); > } > > -*service->service_entry = new_entry; > -save_service_config(service->service_entry); > +err = save_service_config(&new_e

Re: services.exe: Reduce Registry access to KEY_READ or MAXIMUM_ALLOWED wherever possible

2009-11-28 Thread Rob Shearman
2009/11/27 Paul Chitescu : > @@ -376,7 +376,7 @@ > InitializeCriticalSection(&(*db)->cs); > > err = RegCreateKeyExW(HKEY_LOCAL_MACHINE, SZ_SERVICES_KEY, 0, NULL, > - REG_OPTION_NON_VOLATILE, KEY_ALL_ACCESS, NULL, > + REG_OPTION_NON_VOLATIL