Re: shell32: FOF_MULTIDESTFILES must be set when copying files into directory

2008-10-20 Thread Vitaly Perov
is not related to patch shell32: FOF_MULTIDESTFILES must be set when copying files into directory If the translation of rather than is instead of, now I see my fault. But this test is passed in windows (win2k3). It doesn't pass in wine. So, it show difference between windows and wine behaviour. So

Re: shell32: FOF_MULTIDESTFILES must be set when copying files into directory

2008-10-20 Thread Michael Karcher
(testdir2\\test4.txt), Expected the directory 'test4.txt' to exist\n); | +} This test is not related to patch shell32: FOF_MULTIDESTFILES must be set when copying files into directory If the translation of rather than is instead of, now I see my fault. But this test is passed in windows

Re: shell32: FOF_MULTIDESTFILES must be set when copying files into directory

2008-10-18 Thread Vitaly Perov
We've been over this before.  This needs a test case.  Either way, this doesn't look right.  What are you trying to fix? Some program call SHFileOperationW to move one folder to another without FOF_MULTIDESTFILES. The source folder contain subfolders, so SHFileOperationW is called recursively.

Re: shell32: FOF_MULTIDESTFILES must be set when copying files into directory

2008-10-18 Thread James Hawkins
On Sat, Oct 18, 2008 at 5:48 AM, Vitaly Perov [EMAIL PROTECTED] wrote: We've been over this before. This needs a test case. Either way, this doesn't look right. What are you trying to fix? Some program call SHFileOperationW to move one folder to another without FOF_MULTIDESTFILES. The source

Re: shell32: FOF_MULTIDESTFILES must be set when copying files into directory

2008-10-18 Thread Vitaly Perov
You never mentioned a specific program, so I still don't know if this is a real world bug you're running into. Either way, your logic is flawed, as fileOp.pTo is a single directory in this case, so using FOF_MULTIDESTFILES is wrong. MSDN: FOF_MULTIDESTFILES The pTo member specifies

Re: shell32: FOF_MULTIDESTFILES must be set when copying files into directory

2008-10-18 Thread Reece Dunn
2008/10/18 Vitaly Perov [EMAIL PROTECTED]: The program is Garant 7 F1 (Russian legal system database). I don't think you know this program. It is not a real world bug, but there are some significant bugs in SHFileOperationW. I don't think a lot of programs use SHFileOperationW to move a

Re: shell32: FOF_MULTIDESTFILES must be set when copying files into directory

2008-10-18 Thread Vitaly Perov
Thank you for your answer. I agree, that before sending a patch I should write a test first. But the problem is that even a tests are ignored without any explanation. Maybe my tests aren't good, but why anybody just tell what's wrong. Maybe a'm not enough persistent? Have you tried asking on

Re: shell32: FOF_MULTIDESTFILES must be set when copying files into directory

2008-10-18 Thread James Hawkins
On Sat, Oct 18, 2008 at 7:47 AM, Vitaly Perov [EMAIL PROTECTED] wrote: You never mentioned a specific program, so I still don't know if this is a real world bug you're running into. Either way, your logic is flawed, as fileOp.pTo is a single directory in this case, so using

Re: shell32: FOF_MULTIDESTFILES must be set when copying files into directory

2008-10-18 Thread Louis. Lenders
Thank you for your answer. I agree, that before sending a patch I should write a test first. But the problem is that even a tests are ignored without any explanation. Maybe my tests aren't good, but why anybody just tell what's wrong. Seems to be common habit on this list. I hope you're not

Re: shell32: FOF_MULTIDESTFILES must be set when copying files into directory

2008-10-18 Thread James Hawkins
On Sat, Oct 18, 2008 at 5:18 PM, Louis. Lenders [EMAIL PROTECTED] wrote: Thank you for your answer. I agree, that before sending a patch I should write a test first. But the problem is that even a tests are ignored without any explanation. Maybe my tests aren't good, but why anybody just tell

Re: shell32: FOF_MULTIDESTFILES must be set when copying files into directory

2008-10-18 Thread Michael Karcher
Am Samstag, den 18.10.2008, 22:18 + schrieb Louis. Lenders: Spent loads of time for more than 3 years trying to help triaging bugs and helping out in appdb, only to find out that all my patches are ignored silently Sorry, what do you mean by *all* of your patches? This is from the wine

Re: shell32: FOF_MULTIDESTFILES must be set when copying files into directory

2008-10-17 Thread James Hawkins
2008/10/17 Vitaly Perov [EMAIL PROTECTED]: From e2eec69ff86960bd6729a3105747310ce9c256fd Mon Sep 17 00:00:00 2001 From: Vitaly Perov [EMAIL PROTECTED] Date: Fri, 17 Oct 2008 16:56:46 +0400 Subject: [PATCH] shell32: FOF_MULTIDESTFILES must be set when copying files into directory